[PATCH v3 7/9] format-patch: explicitly switch off color when writing to files
- From
Johannes Schindelin <johannes.schindelin@gmx.de>
- Date
- Jun 21, 2016, 10:35 UTC
- Message-ID
- <16e3e24e6f81fa334cfe5535c7a21ec50114bd97.1466505223.git.johannes.schindelin@gmx.de>
- In-Reply-To
- <cover.1466505222.git.johannes.schindelin@gmx.de>
We rely on the auto-detection ("is stdout a terminal?") to determine whether to use color in the output of format-patch or not. That happens to work because we freopen() stdout when redirecting the output to files.
However, we are about to fix that work-around, in which case the auto-detection has no chance to guess whether to use color or not.
But then, we do not need to guess to begin with. We know that we do not want to use ANSI color sequences in the output files. So let's just be explicit about our wishes.
It might be argued that we should only do this when the variable git_use_color_default still has its default value, GIT_COLOR_AUTO. As of 7787570c (format-patch: ignore ui.color, 2011-09-13) we do not allow the ui.color setting to affect format-patch's output, therefore this will always be the case.
Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de> --- builtin/log.c | 1 + 1 file changed, 1 insertion(+)
diff --git a/builtin/log.c b/builtin/log.c index 099f4f7..abd889b 100644 --- a/builtin/log.c +++ b/builtin/log.c @@ -1569,6 +1569,7 @@ int cmd_format_patch(int argc, const char **argv, const char *prefix) setup_pager(); if (output_directory) { + rev.diffopt.use_color = 0; if (use_stdout) die(_("standard output, or directory, which one?")); if (mkdir(output_directory, 0777) < 0 && errno != EEXIST)
-- 2.9.0.118.g0e1a633