Re: [PATCH] fetch: add configuration for making --all default

From: Remi Galan Alfonso <remi.galan-alfonso@ensimag.grenoble-inp.fr>
Date: Jul 17, 2015, 15:02 UTC
Message-ID: <1674906250.515624.1437145366822.JavaMail.zimbra@ensimag.grenoble-inp.fr>
In-Reply-To: <1437139899-6210-1-git-send-email-oystwa@gmail.com>

Hi,

Øystein Walle <oystwa@gmail.com> writes:

> +fetch.all::
> +        If true, fetch will automatically behave as if the `--all`
> +        option was given on the command line uness a remote was given. The
> +        default is false.

s/uness/unless

Show 9 quoted lines

> +test_expect_success 'git fetch (fetch.all = true)' '
> +        (git clone one test9 &&
> +         cd test9 &&
> +         git config fetch.all true &&
> +         git remote add one ../one &&
> +         git remote add two ../two &&
> +         git remote add three ../three &&
> +         git fetch &&
> +         git branch -r > output &&

No space after redirection ('>').
It should be:
         git branch -r >output &&

Show 5 quoted lines

> +test_expect_success 'git fetch one (fetch.all = true)' '
> +        (cd test3 &&
> +         git config fetch.all true &&
> +         git fetch three &&
> +         git branch -r > output &&

Same here

> +         test_cmp ../expect output &&
> +         git fetch --no-all &&
> +         git branch -r > output &&

And here.

> +         test_cmp ../expect output)
> +'

Thanks, Rémi