git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v2 2/2] t0028: add more tests

From
Johannes Sixt <j6t@kdbg.org>
Date
Sep 24, 2019, 06:21 UTC
Message-ID
<163fcc3c-e827-ad15-5987-a2ae93a0bec2@kdbg.org>
In-Reply-To
<40e54cf5ce74d1404187e31c94644df29134b4ff.1569233057.git.gitgitgadget@gmail.com>
Am 23.09.19 um 12:04 schrieb Alexandr Miloslavskiy via GitGitGadget:
Show 7 quoted lines
> From: Alexandr Miloslavskiy <alexandr.miloslavskiy@syntevo.com>
> 
> After I discovered that UTF-16-LE-BOM test was bugged and still
> succeeded, I decided that better tests are required. Possibly the best
> option here is to compare git results against hardcoded ground truth.
> 
> The new tests also cover more interesting chars where (ANSI != UTF-8).

What are we testing here? Is there some back-and-forth conversion going on, and are we testing that the conversion happens at all, or that the correct conversion/encoding is picked, or that the conversion that is finally chosen is correct? Why does it help to test more interesting chars (and would you not also regard codepoints outside the BMP the most interesting because they require surrogate codepoints in UTF-16)?

-- Hannes
Previous: Alexandr MiloslavskiyNext: Alexandr Miloslavskiy
Message 11 of 18 in “t0028 fix test + more tests”
  1. 0/2 t0028 fix test + more testsAlexandr Miloslavskiy via GitGitGadget, Sep 23, 2019
  2. 1/2 t0028: fix test for UTF-16-LE-BOMAlexandr Miloslavskiy via GitGitGadget, Sep 23, 2019
  3. 2/2 t0028: add more testsAlexandr Miloslavskiy via GitGitGadget, Sep 23, 2019
  4. 0/2 Update: fixed typos in commit messageAlexandr Miloslavskiy via GitGitGadget, Sep 23, 2019
  5. 1/2 t0028: fix test for UTF-16-LE-BOMAlexandr Miloslavskiy via GitGitGadget, Sep 23, 2019
  6. Torsten BögershausenSep 24, 2019
  7. Alexandr MiloslavskiySep 24, 2019
  8. 2/2 t0028: add more testsAlexandr Miloslavskiy via GitGitGadget, Sep 23, 2019
  9. Torsten BögershausenSep 24, 2019
  10. Alexandr MiloslavskiySep 24, 2019
  11. Johannes SixtSep 24, 2019
  12. Alexandr MiloslavskiySep 24, 2019
  13. 0/2 Update: fixed typos in commit messageAlexandr Miloslavskiy via GitGitGadget, Sep 24, 2019
  14. 2/2 t0028: add more testsAlexandr Miloslavskiy via GitGitGadget, Sep 24, 2019
  15. Junio C HamanoSep 28, 2019
  16. Alexandr MiloslavskiySep 30, 2019
  17. 1/2 t0028: fix test for UTF-16-LE-BOMAlexandr Miloslavskiy via GitGitGadget, Sep 24, 2019
  18. Torsten BögershausenSep 26, 2019

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.