Re: What's cooking in git.git (Jun 2022, #02; Tue, 7)

From: Philippe Blain <levraiphilippeblain@gmail.com>
Date: Jun 8, 2022, 16:56 UTC
Message-ID: <15dd34af-14c1-5b41-5d33-a2e3b9611c25@gmail.com>
In-Reply-To: <xmqqwndsrm99.fsf@gitster.g>

Hi Junio,

Le 2022-06-07 à 21:12, Junio C Hamano a écrit :

Show 11 quoted lines

> * pb/range-diff-with-submodule (2022-06-06) 1 commit
>   (merged to 'next' on 2022-06-07 at e5e31590c4)
>  + range-diff: show submodule changes irrespective of diff.submodule
> 
>  "git range-diff" did not show anything for submodules that changed
>  in the ranges being compared.  Change the behaviour to include the
>  "--submodule=short" output unconditionally to be compared.
> 
>  Will merge to 'master'.
>  source: <pull.1244.v2.git.1654549153769.gitgitgadget@gmail.com>
>

I think the merge message (and thus the mention in the release notes) could be more precise, maybe something like this:

"git -c diff.submodule=log range-diff" did not show anything for submodules that changed in the ranges being compared, and "git -c diff.submodule=diff range-diff" did not work correctly. Change the behaviour to include the "--submodule=short" output unconditionally to be compared.