git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] rev-list: update a NEEDSWORK comment

From
KHKristoffer Haugsbakk <kristofferhaugsbakk@fastmail.com>
Date
Jul 22, 2025, 08:41 UTC
Message-ID
<1599cd31-436c-4ac7-bbef-be7dfbff00a3@app.fastmail.com>
In-Reply-To
<xmqqecu9w4a5.fsf@gitster.g>
On Tue, Jul 22, 2025, at 00:46, Junio C Hamano wrote:
> The comment was poorly phrased and it wasn't clear what it wanted to
> say.  Strongly discourage this broken pattern to be copied and
> pasted to other code paths.

Why “was”? Shouldn’t it be “The comment is poorly phrased ... so [change it]”. According to SubmittingPatches, “present-tense”.

/nitpick
Previous: Jeff KingNext: Junio C Hamano
Message 8 of 9 in “rev-list: make "struct rev_list_info" static to the only user”
  1. rev-list: make "struct rev_list_info" static to the only userJunio C Hamano, Jul 18, 2025
  2. Jeff KingJul 19, 2025
  3. René ScharfeJul 19, 2025
  4. Jeff KingJul 20, 2025
  5. Junio C HamanoJul 20, 2025
  6. rev-list: update a NEEDSWORK commentJunio C Hamano, Jul 21, 2025
  7. Jeff KingJul 22, 2025
  8. Kristoffer HaugsbakkJul 22, 2025
  9. Junio C HamanoJul 22, 2025

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.