Re: [PATCH 1/2] gitk: Import msgcat for translation support

From: Brett Schwarz <brett_schwarz@yahoo.com>
Date: Jul 28, 2007, 07:28 UTC
Message-ID: <157938.79347.qm@web38908.mail.mud.yahoo.com>

Show 27 quoted lines

> 
> ----- Original Message ----
> From: Paul Mackerras <paulus@samba.org>
> To: Christian Stimming <stimming@tuhh.de>
> Cc: git@vger.kernel.org
> Sent: Friday, July 27, 2007 4:53:28 PM
> Subject: Re: [PATCH 1/2] gitk: Import msgcat for translation support
> 
> Christian Stimming writes:
> 
> > Import tcl's msgcat package to have the [mc...] procedure for  
> > translation available.
> 
> I would prefer
> 
> if {[catch {
>     package require msgcat
>     # rest of your new stuff
> }]} {
>     proc mc {str} {
>     return $str
>     }
> }
> 
> so that everything still works if msgcat isn't available.  In other
> words I don't want to introduce a possible regression by increasing
> gitk's requirements.

Junio already replied to this, and he was correct. However, this made me think of something (that probably should be in git-gui as well) to make it a little more robust. We should check that the msg directory is where we think it is, and either give a warning, or exit the app (I would vote for the former).

So, something like:

set msgdir [file join . msgs]      ;# or whatever this turns out to be
if {[file exists $msgdir]} {
    ::msgcat::mcload $msgdir
} else {
    puts stderr "WTF: can't find message catalog directory"
}

Or you could just use [catch] around the ::msgcat::mcload too.

Regards,
    --brett

       
____________________________________________________________________________________
Moody friends. Drama queens. Your life? Nope! - their life, your story. Play Sims Stories at Yahoo! Games.
http://sims.yahoo.com/