git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 0/5] plugging some list-objects-filter leaks

From
Derrick Stolee <derrickstolee@github.com>
Date
Sep 9, 2022, 14:20 UTC
Message-ID
<15688f6a-4757-e201-9106-663899e35fec@github.com>
In-Reply-To
<Yxl1BNQoy6Drf0Oe@coredump.intra.peff.net>
On 9/8/2022 12:52 AM, Jeff King wrote:
Show 8 quoted lines
> The test I sent earlier in [1] fails the linux-leaks CI job, not because
> it introduces new leaks, but just because it runs existing leaks in a
> test marked as passing-leaks.
> 
> Of course we can drop the passing flag, but I figured it would probably
> be an easy fix. Famous last words. It turned into quite a rabbit hole of
> actual leaks (albeit small and bounded per process) and some
> questionable memory ownership semantics.

Reading the patches, you make good arguments about the various trade- offs in these sticky places. I agree with you in all cases, mostly because the alternatives would not be any better unless we did a _lot_ of work to rewrite a lot more code than these patches. Even then, the benefit is unclear.

> Here's the series I came up with. I'm cc-ing Stolee as the last person
> unfortunate enough to have touched this area. :)
Lucky me!
These patches look good. Thanks!
-Stolee
Previous: Jeff KingNext: Jeff King
Message 7 of 8 in “plugging some list-objects-filter leaks”
  1. 0/5 plugging some list-objects-filter leaksJeff King, Sep 8, 2022
  2. 1/5 list_objects_filter_copy(): deep-copy sparse_oid_name fieldJeff King, Sep 8, 2022
  3. 2/5 transport: deep-copy object-filter struct for fetch-packJeff King, Sep 8, 2022
  4. 3/5 transport: free filter options in disconnect_git()Jeff King, Sep 8, 2022
  5. 4/5 list_objects_filter_options: plug leak of filter_spec stringsJeff King, Sep 8, 2022
  6. 5/5 prepare_repo_settings(): plug leak of config valuesJeff King, Sep 8, 2022
  7. Derrick StoleeSep 9, 2022
  8. Jeff KingSep 11, 2022

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.