git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 7/7] Remove byte-compiler warnings

From
XMXavier Maillard <zedek@gnu.org>
Date
Mar 3, 2007, 10:20 UTC
Message-ID
<15326.1172917246@localhost>
* emacs/git-blame.el: Do not load cl at run-time. Added several defvar
  to silent byte-compiler.
  Interactive form in git-reblame was not correct, fixed that.
Signed-off-by: Xavier Maillard <zedek@gnu.org>
---
 contrib/emacs/git-blame.el |   16 ++++++++++++++--
 1 files changed, 14 insertions(+), 2 deletions(-)
diff --git a/contrib/emacs/git-blame.el b/contrib/emacs/git-blame.el
index 64ad50b..ce029ad 100644
--- a/contrib/emacs/git-blame.el
+++ b/contrib/emacs/git-blame.el
@@ -77,7 +77,8 @@
 ;;
 ;;; Code:
 
-(require 'cl)			      ; to use `push', `pop'
+(eval-when-compile 
+  (require 'cl))			      ; to use `push', `pop'
 
 (defun color-scale (l)
   (let* ((colors ())
@@ -127,11 +128,22 @@
 
 (defvar git-blame-mode nil)
 (make-variable-buffer-local 'git-blame-mode)
+
+(defvar git-blame-current nil)
+(make-variable-buffer-local 'git-blame-current)
+
+(defvar git-blame-file nil)
+(make-variable-buffer-local 'git-blame-file)
+
+(defvar git-blame-colors nil)
+(make-variable-buffer-local 'git-blame-colors)
+
 (unless (assq 'git-blame-mode minor-mode-alist)
   (setq minor-mode-alist
 	(cons (list 'git-blame-mode " blame")
 	      minor-mode-alist)))
 
+
 ;;;###autoload
 (defun git-blame-mode (&optional arg)
   "Minor mode for displaying Git blame"
@@ -157,9 +169,9 @@
 ;;;###autoload
 (defun git-reblame ()
   "Recalculate all blame information in the current buffer"
+  (interactive)
   (unless git-blame-mode
     (error "git-blame is not active"))
-  (interactive)
   (git-blame-cleanup)
   (git-blame-run))
 
-- 
1.5.0
Message 1 of 1 in “Remove byte-compiler warnings”
  1. 7/7 Remove byte-compiler warningsXavier Maillard, Mar 3, 2007

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.