Re: t9020 broken on pu ?

From: Florian Achleitner <florian.achleitner.2.6.31@gmail.com>
Date: Aug 26, 2012, 20:03 UTC
Message-ID: <1518108.91xN7nanEh@flomedio>
In-Reply-To: <503A79EA.4070206@web.de>

On Sunday 26 August 2012 21:32:58 Torsten Bögershausen wrote:

Show 26 quoted lines

> > The reason is that contrib/svn-fe, where remote-svn is in,  is not yet
> > built automatically by the toplevel makefile, so the remote helper can't
> > be found. If you build it manually it should work.
> > Working on it ..
> 
> Hi Florian,
> 
> the compilation as such is started, but gives problems on Mac OS X:
> 
>     CC remote-testsvn.o
> remote-testsvn.c: In function ‘check_or_regenerate_marks’:
> remote-testsvn.c:142: warning: implicit declaration of function ‘getline’
>     CC vcs-svn/line_buffer.o
>     CC vcs-svn/sliding_window.o
>     CC vcs-svn/fast_export.o
>     CC vcs-svn/svndiff.o
>     CC vcs-svn/svndump.o
>     AR vcs-svn/lib.a
>     LINK git-remote-testsvn
> Undefined symbols:
>   "_getline", referenced from:
>       _cmd_import in remote-testsvn.o
>      (maybe you meant: _strbuf_getline)
> ld: symbol(s) not found
> collect2: ld returned 1 exit status
> make: *** [git-remote-testsvn] Error 1

Seems you also don't have getline on Mac OS X. Others already reported that this function may not be available on some platforms. Will be replaced in the next reroll. Thanks for your reviews!

I'm still hesitating to send a new version out, as long as new fixups come in continuously.

-- 
Florian