RE: [PATCH v2] doc: add triangular workflow

From: ALBERTIN TIMOTHEE p1514771 <timothee.albertin@etu.univ-lyon1.fr>
Date: Dec 15, 2017, 15:46 UTC
Message-ID: <1513356398354.33048@etu.univ-lyon1.fr>
In-Reply-To: <xmqqbmj1t4tp.fsf@gitster.mtv.corp.google.com>

Show 6 quoted lines

>>> +This workflow is commonly used on different platforms like BitBucket,
>>> +GitHub or GitLab which provide a dedicated mechanism for requesting merges.
>>
>> As a user, I find it terribly frustrating when reading documentation
>> telling me that "there's a dedicated mechanism" for something without
>> telling me actually how to do it.

>Also I think the description is backwards from end-user's point of
>view.  It's not that it is common to use the workflow on these
>hosting sites.  It's more like people use the workflow and adopt use
>of these hosting sites as one building block of the workflow.

I'm wondering if this sentence is really useful. It's not essential and it will take lot of time and space to talk about it properly. So, if you agree, we'll erase it.

>>> +If **PUBLISH** doesn't exist, a contributor can publish his own repository.
>>> +**PUBLISH** contains modifications before integration.

Show 5 quoted lines

>I am not sure what this really means.  Isn't it the norm to create a
>place to publish your work (and only your work) for your own use?
>IOW, the above two lines solicit questions like "So... what happens
>when publish does already exist??? and where does that publish
>repository come from???"

In the case of a triangular workflow, if the project already exists, PUBLISH will already exist too. However, if the project doesn't exist it is at the creator charge to create it. In fact, we just explain how doing it if the project already exist. We'll add it for the second case. BTW, the line : * `git push` is useless.

Thank you for the review

Timothée Albertin