git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v2] branch: change the error messages to be more meaningful

From
Kaartic Sivaraam <kaarticsivaraam91196@gmail.com>
Date
Oct 4, 2017, 12:46 UTC
Message-ID
<1507121174.2245.3.camel@gmail.com>
In-Reply-To
<xmqqwp4beemb.fsf@gitster.mtv.corp.google.com>
On Wed, 2017-10-04 at 13:11 +0900, Junio C Hamano wrote:
> 
> It is a bit dissapointing that we do not need to touch tests, as it
> indicates that the logic to diagnose extra arguments as an error has
> no coverage.

Even if there were tests I don't think they would have needed any updation as most of the tests (at least those that I came across) that check for failure seem not to be checking for what error message gets printed. They seem to test only if the command fails (using test_must_fail in most cases, I guess).

Moreover, as a consequence of my assumption that the tests don't check for the error messages themselves; I haven't even thought of checking whether the tests or the travis-ci build succeeded as a consequence of my patches that touch "only" the error messages!

--- Kaartic

Previous: Junio C HamanoNext: Junio C Hamano
Message 10 of 12 in “branch: change the error messages to be more meaningful”
  1. branch: change the error messages to be more meaningfulKaartic Sivaraam, Jul 25, 2017
  2. branch: change the error messages to be more meaningfulKaartic Sivaraam, Jul 25, 2017
  3. Kaartic SivaraamJul 25, 2017
  4. branch: change the error messages to be more meaningfulKaartic Sivaraam, Jul 30, 2017
  5. branch: change the error messages to be more meaningfulKaartic Sivaraam, Aug 21, 2017
  6. Kaartic SivaraamOct 2, 2017
  7. Junio C HamanoOct 3, 2017
  8. Kaartic SivaraamOct 3, 2017
  9. Junio C HamanoOct 4, 2017
  10. Kaartic SivaraamOct 4, 2017
  11. Junio C HamanoOct 5, 2017
  12. Kaartic SivaraamOct 5, 2017

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.