git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v2 1/4] mktag: add option which allows the tagger field to be omitted

From
Ian Campbell <ijc@hellion.org.uk>
Date
Sep 19, 2017, 06:42 UTC
Message-ID
<1505803358.4636.4.camel@hellion.org.uk>
In-Reply-To
<xmqqzi9rqtmn.fsf@gitster.mtv.corp.google.com>
On Tue, 2017-09-19 at 12:01 +0900, Junio C Hamano wrote:
Show 18 quoted lines
> 
> Hmph.  I cannot shake this nagging feeling that this is probably a
> solution that is overly narrow to a single problem that won't scale
> into the future.
> 
> [...snip good point...]
> 
> If we drop the "verification" step from the above, that essentially
> becomes an equivaent to "hash-object -t tag -w --stdin".
> 
> So I now have to wonder if it may be sufficient to use "hash-object"
> in filter-branch, without doing this "allow malformed data that we
> would not permit if the tag were being created today, only to help
> replaying an old, already broken data" change to "git mktag".
> 
> Is there something that makes "hash-object" insufficient (like it
> still does some extra checks we would want to disable and cannot
> work as a replacement for your "--allow-missing-tagger")?

I've done a couple of quick tests and it looks like it will work. I'll run a few more checks and repost.

Ian.
Previous: Junio C HamanoNext: Ian Campbell
Message 4 of 8 in “filter-branch: support for incremental update + fix for ancient tag format”
  1. 0/4 filter-branch: support for incremental update + fix for ancient tag formatIan Campbell, Sep 17, 2017
  2. 1/4 mktag: add option which allows the tagger field to be omittedIan Campbell, Sep 17, 2017
  3. Junio C HamanoSep 19, 2017
  4. Ian CampbellSep 19, 2017
  5. 4/4 Subject: filter-branch: stash away ref map in a branchIan Campbell, Sep 17, 2017
  6. Ian CampbellSep 17, 2017
  7. 3/4 filter-branch: preserve and restore $GIT_AUTHOR_* and $GIT_COMMITTER_*Ian Campbell, Sep 17, 2017
  8. 2/4 filter-branch: reset $GIT_* before cleaning upIan Campbell, Sep 17, 2017

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.