git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 2/2] filter-branch: Handle rewritting (very) old style tags which lack tagger

From
Ian Campbell <ijc@hellion.org.uk>
Date
Aug 9, 2017, 19:02 UTC
Message-ID
<1502305353.2735.33.camel@hellion.org.uk>
In-Reply-To
<xmqqlgms7nbl.fsf@gitster.mtv.corp.google.com>
On Wed, 2017-08-09 at 08:50 -0700, Junio C Hamano wrote:
Show 18 quoted lines
> Jeff King <peff@peff.net> writes:
> 
> > On Tue, Aug 08, 2017 at 09:06:20AM +0100, Ian Campbell wrote:
> >
> >> Such as v2.6.12-rc2..v2.6.13-rc3 in the Linux kernel source tree.
> >> 
> >> Insert a fake tag header, since newer `git mktag` wont accept the
> input
> >> otherwise:
> >
> > Hmm. Now your resulting tag will have this crufty "unknown@example.
> com"
> > header baked into it, won't it?
> >
> > Should we instead make git-mktag more lenient (possibly with a
> > command-line option to reduce accidental omissions)?
> 
> That sounds sensible. Thanks for injecting a dose of sanity.

Indeed. I'll add a --allow-missing-tagger option (suggestions for a snappier name accepted!) and pass it unconditionally from the filter- branch script.

Ian.
Previous: Junio C HamanoNext: Junio C Hamano
Message 10 of 12 in “filter-branch: support for incremental update + fix for ancient tag format”
  1. 0/2 filter-branch: support for incremental update + fix for ancient tag formatIan Campbell, Aug 8, 2017
  2. 1/2 filter-branch: Add --state-branch to hold pickled copy of ref mapIan Campbell, Aug 8, 2017
  3. Junio C HamanoAug 8, 2017
  4. Ian CampbellAug 9, 2017
  5. 2/2 filter-branch: Handle rewritting (very) old style tags which lack taggerIan Campbell, Aug 8, 2017
  6. Junio C HamanoAug 8, 2017
  7. Ian CampbellAug 9, 2017
  8. Jeff KingAug 9, 2017
  9. Junio C HamanoAug 9, 2017
  10. Ian CampbellAug 9, 2017
  11. Junio C HamanoAug 9, 2017
  12. Jeff KingAug 9, 2017

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.