git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 1/3] Allow debugging unsafe directories' ownership

From
Johannes Schindelin <johannes.schindelin@gmx.de>
Date
Aug 8, 2022, 13:29 UTC
Message-ID
<14q05972-5507-21n5-p61o-qq62366n6nsp@tzk.qr>
In-Reply-To
<8rqqnqp1-q613-ron6-6q8s-n7sq57o980q9@tzk.qr>
Hi Junio,
On Fri, 15 Jul 2022, Johannes Schindelin wrote:
Show 23 quoted lines
> On Thu, 14 Jul 2022, Junio C Hamano wrote:
>
> > Junio C Hamano <gitster@pobox.com> writes:
> >
> > > ... I am not sure about this part.  Do we have any other codepath to
> > > show "to debug, run the program with this" suggestion?  Adding it in
> > > the documentation is probably good, but this is an extra message
> > > that is much larger than the "owned by X but you are Y" message that
> > > would be shown.  With or without the environment set, the output
> > > will become noisier with this patch.  I wonder if we are better off
> > > giving the information that is given in the warning (in compat/ part
> > > of the patch) _unconditionally_ in the message, which would make it
> > > less noisy overall.
> >
> > I am wondering if passing a struct to allow is_path_owned_by*()
> > helper(s) to report the detail of the failures they discover a
> > cleaner way to do this.  To illustrate what I meant, along the
> > lines of the following patch, with any additional code to actually
> > stuff messages in the strbuf report, in the is_path_owned_by*()
> > implementation.
>
> I like it! Let me play with this, after this coming week (during which I
> plan to be mostly offline).

I had to play with it for a while until I could make it work, but eventually I managed to do it. The second iteration was just sent, and implements this route.

Thank you, Dscho

Previous: Johannes SchindelinNext: Johannes Schindelin via GitGitGadget
Message 6 of 16 in “Some improvements to safe.directory on Windows”
  1. 0/3 Some improvements to safe.directory on WindowsJohannes Schindelin via GitGitGadget, Jul 13, 2022
  2. 1/3 Allow debugging unsafe directories' ownershipJohannes Schindelin via GitGitGadget, Jul 13, 2022
  3. Junio C HamanoJul 13, 2022
  4. Junio C HamanoJul 14, 2022
  5. Johannes SchindelinJul 15, 2022
  6. Johannes SchindelinAug 8, 2022
  7. 2/3 mingw: handle a file owned by the Administrators group correctlyJohannes Schindelin via GitGitGadget, Jul 13, 2022
  8. 3/3 mingw: be more informative when ownership check fails on FAT32Johannes Schindelin via GitGitGadget, Jul 13, 2022
  9. 0/5 Some improvements to safe.directory on WindowsJohannes Schindelin via GitGitGadget, Aug 8, 2022
  10. 1/5 setup: fix some formattingJohannes Schindelin via GitGitGadget, Aug 8, 2022
  11. 2/5 Prepare for more detailed "dubious ownership" messagesJohannes Schindelin via GitGitGadget, Aug 8, 2022
  12. 3/5 mingw: provide details about unsafe directories' ownershipJohannes Schindelin via GitGitGadget, Aug 8, 2022
  13. 4/5 mingw: be more informative when ownership check fails on FAT32Johannes Schindelin via GitGitGadget, Aug 8, 2022
  14. 5/5 mingw: handle a file owned by the Administrators group correctlyJohannes Schindelin via GitGitGadget, Aug 8, 2022
  15. Junio C HamanoAug 8, 2022
  16. Johannes SchindelinAug 9, 2022

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.