[PATCH 2/4 v4] revision.c: swap if/else blocks
- From
Siddharth Kannan <kannan.siddharth12@gmail.com>
- Date
- Feb 16, 2017, 15:14 UTC
- Message-ID
- <1487258054-32292-3-git-send-email-kannan.siddharth12@gmail.com>
- In-Reply-To
- <1487258054-32292-1-git-send-email-kannan.siddharth12@gmail.com>
Swap the condition and bodies of an "if (A) do_A else do_B" in setup_revisions() to "if (!A) do_B else do_A", to make the change in the the next step easier to read.
No behaviour change is intended in this step.
Signed-off-by: Siddharth Kannan <kannan.siddharth12@gmail.com> --- revision.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/revision.c b/revision.c index 5674a9a..8d4ddae 100644 --- a/revision.c +++ b/revision.c @@ -2238,7 +2238,9 @@ int setup_revisions(int argc, const char **argv, struct rev_info *revs, struct s } - if (handle_revision_arg(arg, revs, flags, revarg_opt)) { + if (!handle_revision_arg(arg, revs, flags, revarg_opt)) + got_rev_arg = 1; + else { int j; if (seen_dashdash || *arg == '^') die("bad revision '%s'", arg); @@ -2255,8 +2257,6 @@ int setup_revisions(int argc, const char **argv, struct rev_info *revs, struct s append_prune_data(&prune_data, argv + i); break; } - else - got_rev_arg = 1; } if (prune_data.nr) {
-- 2.1.4