Re: [PATCH v4 05/14] i18n: add--interactive: mark plural strings
- From
Vasco Almeida <vascomalmeida@sapo.pt>
- Date
- Oct 20, 2016, 16:35 UTC
- Message-ID
- <1476981335.14459.19.camel@sapo.pt>
- In-Reply-To
- <20161010125449.7929-6-vascomalmeida@sapo.pt>
A Seg, 10-10-2016 às 12:54 +0000, Vasco Almeida escreveu:
Show 6 quoted lines
> @@ -70,6 +72,8 @@ Git::I18N - Perl interface to Git's Gettext localizations
>
> printf __("The following error occurred: %s\n"), $error;
>
> + printf __n("commited %d file", "commited %d files", $files), $files;
> +I forgot to add \n to this example as suggested in <xmqqoa2ymnb1.fsf@gitster.mtv.corp.google.com>
What should I do? Should I wait for more reviews and then send a new re-roll fixing this?