[PATCH v2] http: http.emptyauth should allow empty (not just NULL) usernames
- From
David Turner <dturner@twosigma.com>
- Date
- Oct 4, 2016, 14:53 UTC
- Message-ID
- <1475592832-26545-1-git-send-email-dturner@twosigma.com>
When using Kerberos authentication with newer versions of libcurl, CURLOPT_USERPWD must be set to a value, even if it is an empty value. The value is never sent to the server. Previous versions of libcurl did not require this variable to be set. One way that some users express the empty username/password is http://:@gitserver.example.com, which http.emptyauth was designed to support. Another, equivalent, URL is http://@gitserver.example.com. The latter leads to a username of zero-length, rather than a NULL username, but CURLOPT_USERPWD still needs to be set (if http.emptyauth is set). Do so.
Signed-off-by: David Turner <dturner@twosigma.com> --- Same patch, different message. --- http.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/http.c b/http.c index 82ed542..bd0dba2 100644 --- a/http.c +++ b/http.c @@ -351,7 +351,7 @@ static int http_options(const char *var, const char *value, void *cb) static void init_curl_http_auth(CURL *result) { - if (!http_auth.username) { + if (!http_auth.username || !*http_auth.username) { if (curl_empty_auth) curl_easy_setopt(result, CURLOPT_USERPWD, ":"); return;
-- 2.8.0.rc4.22.g8ae061a