[PATCH] http: http.emptyauth should allow empty (not just NULL) usernames
- From
David Turner <dturner@twosigma.com>
- Date
- Oct 3, 2016, 17:19 UTC
- Message-ID
- <1475515168-29679-1-git-send-email-dturner@twosigma.com>
When using kerberos authentication, one URL pattern which is allowed is http://@gitserver.example.com. This leads to a username of zero-length, rather than a NULL username. But the two cases should be treated the same by http.emptyauth.
Signed-off-by: David Turner <dturner@twosigma.com> --- http.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/http.c b/http.c index 82ed542..bd0dba2 100644 --- a/http.c +++ b/http.c @@ -351,7 +351,7 @@ static int http_options(const char *var, const char *value, void *cb) static void init_curl_http_auth(CURL *result) { - if (!http_auth.username) { + if (!http_auth.username || !*http_auth.username) { if (curl_empty_auth) curl_easy_setopt(result, CURLOPT_USERPWD, ":"); return;
-- 2.8.0.rc4.22.g8ae061a