git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH v7 06/19] daemonize(): set a flag before exiting the main process

From
David Turner <dturner@twopensource.com>
Date
Apr 30, 2016, 01:02 UTC
Message-ID
<1461978133-13966-7-git-send-email-dturner@twopensource.com>
In-Reply-To
<1461978133-13966-1-git-send-email-dturner@twopensource.com>
From: Nguyễn Thái Ngọc Duy <pclouds@gmail.com>

This allows signal handlers and atexit functions to realize this situation and not clean up.

Signed-off-by: Nguyễn Thái Ngọc Duy <pclouds@gmail.com>
Signed-off-by: David Turner <dturner@twopensource.com>
---
 builtin/gc.c | 2 +-
 cache.h      | 2 +-
 daemon.c     | 2 +-
 setup.c      | 4 +++-
 4 files changed, 6 insertions(+), 4 deletions(-)
diff --git a/builtin/gc.c b/builtin/gc.c
index c583aad..37180de 100644
--- a/builtin/gc.c
+++ b/builtin/gc.c
@@ -385,7 +385,7 @@ int cmd_gc(int argc, const char **argv, const char *prefix)
 			 * failure to daemonize is ok, we'll continue
 			 * in foreground
 			 */
-			daemonized = !daemonize();
+			daemonized = !daemonize(NULL);
 		}
 	} else
 		add_repack_all_option();
diff --git a/cache.h b/cache.h
index 6cb0d02..4c1529a 100644
--- a/cache.h
+++ b/cache.h
@@ -539,7 +539,7 @@ extern int set_git_dir_init(const char *git_dir, const char *real_git_dir, int);
 extern int init_db(const char *template_dir, unsigned int flags);
 
 extern void sanitize_stdfds(void);
-extern int daemonize(void);
+extern int daemonize(int *);
 
 #define alloc_nr(x) (((x)+16)*3/2)
 
diff --git a/daemon.c b/daemon.c
index 8d45c33..a5cf954 100644
--- a/daemon.c
+++ b/daemon.c
@@ -1365,7 +1365,7 @@ int main(int argc, char **argv)
 		return execute();
 
 	if (detach) {
-		if (daemonize())
+		if (daemonize(NULL))
 			die("--detach not supported on this platform");
 	} else
 		sanitize_stdfds();
diff --git a/setup.c b/setup.c
index de1a2a7..9adf13f 100644
--- a/setup.c
+++ b/setup.c
@@ -1017,7 +1017,7 @@ void sanitize_stdfds(void)
 		close(fd);
 }
 
-int daemonize(void)
+int daemonize(int *daemonized)
 {
 #ifdef NO_POSIX_GOODIES
 	errno = ENOSYS;
@@ -1029,6 +1029,8 @@ int daemonize(void)
 		case -1:
 			die_errno("fork failed");
 		default:
+			if (daemonized)
+				*daemonized = 1;
 			exit(0);
 	}
 	if (setsid() == -1)
-- 
2.4.2.767.g62658d5-twtrsrc
Previous: David TurnerNext: David Turner
Message 7 of 20 in “index-helper/watchman”
  1. 00/19 index-helper/watchmanDavid Turner, Apr 30, 2016
  2. 01/19 read-cache.c: fix constness of verify_hdr()David Turner, Apr 30, 2016
  3. 02/19 read-cache: allow to keep mmap'd memory after readingDavid Turner, Apr 30, 2016
  4. 03/19 index-helper: new daemon for caching index and related stuffDavid Turner, Apr 30, 2016
  5. 04/19 index-helper: add --strictDavid Turner, Apr 30, 2016
  6. 05/19 index-helper: log warningsDavid Turner, Apr 30, 2016
  7. 06/19 daemonize(): set a flag before exiting the main processDavid Turner, Apr 30, 2016
  8. 07/19 index-helper: add --detachDavid Turner, Apr 30, 2016
  9. 08/19 read-cache: add watchman 'WAMA' extensionDavid Turner, Apr 30, 2016
  10. 09/19 Add watchman support to reduce index refresh costDavid Turner, Apr 30, 2016
  11. 10/19 index-helper: use watchman to avoid refreshing index with lstat()David Turner, Apr 30, 2016
  12. 11/19 update-index: enable/disable watchman supportDavid Turner, Apr 30, 2016
  13. 12/19 unpack-trees: preserve index extensionsDavid Turner, Apr 30, 2016
  14. 13/19 watchman: add a config option to enable the extensionDavid Turner, Apr 30, 2016
  15. 14/19 index-helper: kill modeDavid Turner, Apr 30, 2016
  16. 15/19 index-helper: don't run if already runningDavid Turner, Apr 30, 2016
  17. 16/19 index-helper: autorun modeDavid Turner, Apr 30, 2016
  18. 17/19 index-helper: optionally automatically runDavid Turner, Apr 30, 2016
  19. 18/19 Add tracing to measure where most of the time is spentDavid Turner, Apr 30, 2016
  20. 19/19 untracked-cache: config optionDavid Turner, Apr 30, 2016

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.