git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH v5 14/16] branch, tag: use porcelain output

From
Karthik Nayak <karthik.188@gmail.com>
Date
Apr 22, 2016, 19:04 UTC
Message-ID
<1461351847-22903-15-git-send-email-Karthik.188@gmail.com>
In-Reply-To
<1461351847-22903-1-git-send-email-Karthik.188@gmail.com>

Call ref-filter's setup_ref_filter_porcelain_msg() to enable translated messages for the %(upstream:tack) atom. Although branch.c doesn't currently use ref-filter's printing API's, this will ensure that when it does in the future patches, we do not need to worry about translation.

Written-by: Matthieu Moy <matthieu.moy@grenoble-inp.fr>
Mentored-by: Christian Couder <christian.couder@gmail.com>
Mentored-by: Matthieu Moy <matthieu.moy@grenoble-inp.fr>
Signed-off-by: Karthik Nayak <karthik.188@gmail.com>
---
 builtin/branch.c | 2 ++
 builtin/tag.c    | 2 ++
 2 files changed, 4 insertions(+)
diff --git a/builtin/branch.c b/builtin/branch.c
index d467840..ecd7ffc 100644
--- a/builtin/branch.c
+++ b/builtin/branch.c
@@ -632,6 +632,8 @@ int cmd_branch(int argc, const char **argv, const char *prefix)
 		OPT_END(),
 	};
 
+	setup_ref_filter_porcelain_msg();
+
 	memset(&filter, 0, sizeof(filter));
 	filter.kind = FILTER_REFS_BRANCHES;
 	filter.abbrev = -1;
diff --git a/builtin/tag.c b/builtin/tag.c
index 528a1ba..3b51be1 100644
--- a/builtin/tag.c
+++ b/builtin/tag.c
@@ -379,6 +379,8 @@ int cmd_tag(int argc, const char **argv, const char *prefix)
 		OPT_END()
 	};
 
+	setup_ref_filter_porcelain_msg();
+
 	git_config(git_tag_config, sorting_tail);
 
 	memset(&opt, 0, sizeof(opt));
-- 
2.8.0
Previous: Karthik NayakNext: Karthik Nayak
Message 15 of 17 in “port branch.c to use ref-filter's printing options”
  1. 00/16 port branch.c to use ref-filter's printing optionsKarthik Nayak, Apr 22, 2016
  2. 01/16 ref-filter: include reference to 'used_atom' within 'atom_value'Karthik Nayak, Apr 22, 2016
  3. 02/16 ref-filter: implement %(if:equals=<string>) and %(if:notequals=<string>)Karthik Nayak, Apr 22, 2016
  4. 03/16 ref-filter: modify "%(objectname:short)" to take lengthKarthik Nayak, Apr 22, 2016
  5. 04/16 ref-filter: move get_head_description() from branch.cKarthik Nayak, Apr 22, 2016
  6. 05/16 ref-filter: introduce format_ref_array_item()Karthik Nayak, Apr 22, 2016
  7. 06/16 ref-filter: make %(upstream:track) prints "[gone]" for invalid upstreamsKarthik Nayak, Apr 22, 2016
  8. 07/16 ref-filter: add support for %(upstream:track,nobracket)Karthik Nayak, Apr 22, 2016
  9. 08/16 ref-filter: make "%(symref)" atom work with the ':short' modifierKarthik Nayak, Apr 22, 2016
  10. 09/16 ref-filter: introduce refname_atom_parser_internal()Karthik Nayak, Apr 22, 2016
  11. 10/16 ref-filter: introduce symref_atom_parser() and refname_atom_parser()Karthik Nayak, Apr 22, 2016
  12. 11/16 ref-filter: make remote_ref_atom_parser() use refname_atom_parser_internal()Karthik Nayak, Apr 22, 2016
  13. 12/16 ref-filter: add `:dir` and `:base` options for ref printing atomsKarthik Nayak, Apr 22, 2016
  14. 13/16 ref-filter: allow porcelain to translate messages in the outputKarthik Nayak, Apr 22, 2016
  15. 14/16 branch, tag: use porcelain outputKarthik Nayak, Apr 22, 2016
  16. 15/16 branch: use ref-filter printing APIsKarthik Nayak, Apr 22, 2016
  17. 16/16 branch: implement '--format' optionKarthik Nayak, Apr 22, 2016

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.