git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 5/7] t7407: make expectation as clear as possible

From
Stefan Beller <sbeller@google.com>
Date
Mar 28, 2016, 23:28 UTC
Message-ID
<1459207703-1635-6-git-send-email-sbeller@google.com>
In-Reply-To
<1459207703-1635-1-git-send-email-sbeller@google.com>

Not everyone (including me) grasps the sed expression in a split second as they would grasp the 4 lines printed as is.

Signed-off-by: Stefan Beller <sbeller@google.com>
---
 t/t7407-submodule-foreach.sh | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)
diff --git a/t/t7407-submodule-foreach.sh b/t/t7407-submodule-foreach.sh
index 776b349..808c6c6 100755
--- a/t/t7407-submodule-foreach.sh
+++ b/t/t7407-submodule-foreach.sh
@@ -262,8 +262,12 @@ test_expect_success 'test "status --recursive"' '
 	test_cmp expect actual
 '
 
-sed -e "/nested2 /s/.*/+$nested2sha1 nested1\/nested2 (file2~1)/;/sub[1-3]/d" < expect > expect2
-mv -f expect2 expect
+cat > expect <<EOF
+ $nested1sha1 nested1 (heads/master)
++$nested2sha1 nested1/nested2 (file2~1)
+ $nested3sha1 nested1/nested2/nested3 (heads/master)
+ $submodulesha1 nested1/nested2/nested3/submodule (heads/master)
+EOF
 
 test_expect_success 'ensure "status --cached --recursive" preserves the --cached flag' '
 	(
-- 
2.8.0.rc4.23.gd22361a.dirty
Previous: Stefan BellerNext: Junio C Hamano
Message 14 of 17 in “Fix path bugs in submodule commands executed from sub dir [WAS: submodule--helper clone: lose the extra prefix option]”
  1. 0/7 Fix path bugs in submodule commands executed from sub dir [WAS: submodule--helper clone: lose the extra prefix option]Stefan Beller, Mar 28, 2016
  2. 1/7 submodule foreach: test path handling in recursive submodulesStefan Beller, Mar 28, 2016
  3. 2/7 submodule foreach: correct path computation in recursive submodulesStefan Beller, Mar 28, 2016
  4. Junio C HamanoMar 29, 2016
  5. Junio C HamanoMar 29, 2016
  6. Stefan BellerMar 29, 2016
  7. Stefan BellerMar 29, 2016
  8. 3/7 submodule update --init: test path handling in recursive submodulesStefan Beller, Mar 28, 2016
  9. Junio C HamanoMar 29, 2016
  10. 4/7 submodule update --init: correct path handling in recursive submodulesStefan Beller, Mar 28, 2016
  11. Junio C HamanoMar 29, 2016
  12. Junio C HamanoMar 29, 2016
  13. Stefan BellerMar 29, 2016
  14. 5/7 t7407: make expectation as clear as possibleStefan Beller, Mar 28, 2016
  15. Junio C HamanoMar 29, 2016
  16. 6/7 submodule status: test path handling in recursive submodulesStefan Beller, Mar 28, 2016
  17. 7/7 submodule status: fix path handling in recursive submodulesStefan Beller, Mar 28, 2016

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.