git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCHv3 0/5] submodule helper: cleanup prefix passing

From
Stefan Beller <sbeller@google.com>
Date
Mar 25, 2016, 18:39 UTC
Message-ID
<1458931156-29125-1-git-send-email-sbeller@google.com>

Thanks Junio for the in-depth discussion! I squashed the first two commits as they are actually fixing the same underlying issue. Setting wt_prefix=<empty> is the actual preparation for switching the submodule--helper to git -C instead of "--prefix$prefix". But setting wt_prefix=empty would break existing tests, so the different computation of the prefix (relative_path of sm_path instead of plain sm_path) is the fix of the fix.

Eric, I picked up the git -C in the tests, which are broken into 2 patches and have a more concise commit message each.

Jacob, thanks for your 
  Reviewed-by: Jacob Keller <jacob.e.keller@intel.com>
although I changed the code so much, that I did not put it in this series.

New in this series is the last commit, which gets rid of the prefix for "submodule--helper clone". (It was useless to begin with; probably just cargo-culted in because we had it in "submodule--helper list")

Thanks, Stefan

Stefan Beller (5):
  submodule: prepare recursive path from non root directory
  submodule--helper list: lose the extra prefix option
  submodule update: add test for recursive from non root dir
  submodule sync: test syncing one submodule
  submodule--helper clone: lose the extra prefix option
 builtin/submodule--helper.c | 10 ++--------
 git-submodule.sh            | 23 +++++++++++++----------
 t/t7403-submodule-sync.sh   | 13 +++++++++----
 t/t7406-submodule-update.sh | 14 +++++++++++---
 4 files changed, 35 insertions(+), 25 deletions(-)
-- 
2.8.0.rc4.10.g52f3f33.dirty
Next: Stefan Beller
Message 1 of 15 in “[PATCHv3 0/5] submodule helper: cleanup prefix passing”
  1. Stefan BellerMar 25, 2016
  2. 1/5 submodule: prepare recursive path from non root directoryStefan Beller, Mar 25, 2016
  3. Junio C HamanoMar 25, 2016
  4. 2/5 submodule--helper list: lose the extra prefix optionStefan Beller, Mar 25, 2016
  5. 3/5 submodule update: add test for recursive from non root dirStefan Beller, Mar 25, 2016
  6. 4/5 submodule sync: test syncing one submoduleStefan Beller, Mar 25, 2016
  7. 5/5 submodule--helper clone: lose the extra prefix optionStefan Beller, Mar 25, 2016
  8. Junio C HamanoMar 25, 2016
  9. Junio C HamanoMar 25, 2016
  10. Stefan BellerMar 25, 2016
  11. Junio C HamanoMar 25, 2016
  12. Stefan BellerMar 25, 2016
  13. Junio C HamanoMar 25, 2016
  14. Stefan BellerMar 25, 2016
  15. Junio C HamanoMar 28, 2016

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.