git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH] Fixing segmentation fault when merging FETCH_HEAD

From
JFJose Ivan B. Vilarouca Filho <joseivan@lavid.ufpb.br>
Date
Mar 19, 2016, 18:17 UTC
Message-ID
<1458411460-26146-1-git-send-email-joseivan@lavid.ufpb.br>
From: "Jose Ivan B. Vilarouca Filho" <joseivan@lavid.ufpb.br>

A segmentaion fault is raised when trying to merge FETCH_HEAD formed only by "not-for-merge" refs.

Ex:
    git init .
    git remote add origin ...
    git fetch origin
    git merge FETCH_HEAD
Signed-off-by: Jose Ivan B. Vilarouca Filho <joseivan@lavid.ufpb.br>
---
 builtin/merge.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/builtin/merge.c b/builtin/merge.c
index 101ffef..7e419dc 100644
--- a/builtin/merge.c
+++ b/builtin/merge.c
@@ -1270,9 +1270,9 @@ int cmd_merge(int argc, const char **argv, const char *prefix)
 			    "an empty head"));
 		remoteheads = collect_parents(head_commit, &head_subsumed,
 					      argc, argv, NULL);
-		remote_head = remoteheads->item;
-		if (!remote_head)
+		if ((!remoteheads) || (!remoteheads->item))
 			die(_("%s - not something we can merge"), argv[0]);
+		remote_head = remoteheads->item;
 		if (remoteheads->next)
 			die(_("Can merge only exactly one commit into empty head"));
 		read_empty(remote_head->object.oid.hash, 0);
-- 
1.7.10.4
Next: Eric Sunshine
Message 1 of 6 in “Fixing segmentation fault when merging FETCH_HEAD”
  1. Fixing segmentation fault when merging FETCH_HEADJose Ivan B. Vilarouca Filho, Mar 19, 2016
  2. Eric SunshineMar 20, 2016
  3. Jose Ivan B. Vilarouca FilhoMar 21, 2016
  4. Eric SunshineMar 21, 2016
  5. merge: fix NULL pointer dereference when merging nothing into voidJunio C Hamano, Mar 21, 2016
  6. Eric SunshineMar 21, 2016

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.