[PATCHv20 08/12] run_processes_parallel: correctly terminate callbacks with an LF
- From
Stefan Beller <sbeller@google.com>
- Date
- Feb 29, 2016, 19:14 UTC
- Message-ID
- <1456773250-5510-9-git-send-email-sbeller@google.com>
- In-Reply-To
- <1456773250-5510-1-git-send-email-sbeller@google.com>
As the strbufs passed around collect all output to the user, and there is no post processing involved we need to care about the line ending ourselves.
Reviewed-by: Jonathan Nieder <jrnieder@gmail.com> Signed-off-by: Stefan Beller <sbeller@google.com> Signed-off-by: Junio C Hamano <gitster@pobox.com> --- run-command.c | 2 ++ 1 file changed, 2 insertions(+)
diff --git a/run-command.c b/run-command.c index d2964e1..6fad42f 100644 --- a/run-command.c +++ b/run-command.c @@ -912,6 +912,7 @@ int default_start_failure(struct child_process *cp, strbuf_addstr(out, "Starting a child failed:"); for (i = 0; cp->argv[i]; i++) strbuf_addf(out, " %s", cp->argv[i]); + strbuf_addch(out, '\n'); return 0; } @@ -930,6 +931,7 @@ int default_task_finished(int result, strbuf_addf(out, "A child failed with return code %d:", result); for (i = 0; cp->argv[i]; i++) strbuf_addf(out, " %s", cp->argv[i]); + strbuf_addch(out, '\n'); return 0; }
-- 2.7.0.rc0.37.gb7b9e8e