git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 0/2] Submodule harden fetches (WAS: submodule: Fetch the direct sha1 first)

From
Stefan Beller <sbeller@google.com>
Date
Feb 22, 2016, 22:35 UTC
Message-ID
<1456180548-20996-1-git-send-email-sbeller@google.com>
A simple patch evolves into a series!

First we'll fix a bug by adding the --objects switch to rev-list to have a stricter check for the desired commit to be there. IIUC this is not 100% right yet, but it improves the situation.

The second patch introduces an extra fetch in case the first fetch did not yield the expected commit, using the pattern

    # first 4 lines unchanged:
    if $sha1's history and objects are incomplete:
        fetch ;# normally just like we have done before
    else 
        die ...
    # new code:     
    if $sha1's history and objects are still incomplete:
        fetch $sha1
    else
        die ... 
        
Thanks,
Stefan
Stefan Beller (2):
  submodule: Include check for objects when fetching
  submodule: Try harder to fetch needed sha1 by direct fetching sha1
 git-submodule.sh | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)
-- 
2.7.0.rc0.34.ga06e0b3.dirty
Next: Stefan Beller
Message 1 of 10 in “Submodule harden fetches (WAS: submodule: Fetch the direct sha1 first)”
  1. 0/2 Submodule harden fetches (WAS: submodule: Fetch the direct sha1 first)Stefan Beller, Feb 22, 2016
  2. 1/2 submodule: Include check for objects when fetchingStefan Beller, Feb 22, 2016
  3. Junio C HamanoFeb 22, 2016
  4. Junio C HamanoFeb 22, 2016
  5. Junio C HamanoFeb 22, 2016
  6. 2/2 submodule: Try harder to fetch needed sha1 by direct fetching sha1Stefan Beller, Feb 22, 2016
  7. Junio C HamanoFeb 23, 2016
  8. Stefan BellerFeb 23, 2016
  9. Junio C HamanoFeb 23, 2016
  10. submodule: Try harder to fetch needed sha1 by direct fetching sha1Stefan Beller, Feb 24, 2016

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.