git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 19/22] trace.h: use the FORMATPRINTF macro to declare the gcc function attribute 'format printf'

From
Elia Pinto <gitter.spiros@gmail.com>
Date
Feb 11, 2016, 12:38 UTC
Message-ID
<1455194339-859-20-git-send-email-gitter.spiros@gmail.com>
In-Reply-To
<1455194339-859-1-git-send-email-gitter.spiros@gmail.com>

Use the new FORMATPRINTF macro (in git-compat-util.h) to declare the gcc function attribute 'format printf'

Signed-off-by: Elia Pinto <gitter.spiros@gmail.com>
---
 trace.h | 16 ++++++++--------
 1 file changed, 8 insertions(+), 8 deletions(-)
diff --git a/trace.h b/trace.h
index 179b249..14df130 100644
--- a/trace.h
+++ b/trace.h
@@ -22,23 +22,23 @@ extern void trace_verbatim(struct trace_key *key, const void *buf, unsigned len)
 
 #ifndef HAVE_VARIADIC_MACROS
 
-__attribute__((format (printf, 1, 2)))
+FORMATPRINTF(1,2)
 extern void trace_printf(const char *format, ...);
 
-__attribute__((format (printf, 2, 3)))
+FORMATPRINTF(2,3)
 extern void trace_printf_key(struct trace_key *key, const char *format, ...);
 
-__attribute__((format (printf, 2, 3)))
+FORMATPRINTF(2,3)
 extern void trace_argv_printf(const char **argv, const char *format, ...);
 
 extern void trace_strbuf(struct trace_key *key, const struct strbuf *data);
 
 /* Prints elapsed time (in nanoseconds) if GIT_TRACE_PERFORMANCE is enabled. */
-__attribute__((format (printf, 2, 3)))
+FORMATPRINTF(2,3)
 extern void trace_performance(uint64_t nanos, const char *format, ...);
 
 /* Prints elapsed time since 'start' if GIT_TRACE_PERFORMANCE is enabled. */
-__attribute__((format (printf, 2, 3)))
+FORMATPRINTF(2,3)
 extern void trace_performance_since(uint64_t start, const char *format, ...);
 
 #else
@@ -97,15 +97,15 @@ extern void trace_performance_since(uint64_t start, const char *format, ...);
 			     __VA_ARGS__)
 
 /* backend functions, use non-*fl macros instead */
-__attribute__((format (printf, 4, 5)))
+FORMATPRINTF(4,5)
 extern void trace_printf_key_fl(const char *file, int line, struct trace_key *key,
 				const char *format, ...);
-__attribute__((format (printf, 4, 5)))
+FORMATPRINTF(4,5)
 extern void trace_argv_printf_fl(const char *file, int line, const char **argv,
 				 const char *format, ...);
 extern void trace_strbuf_fl(const char *file, int line, struct trace_key *key,
 			    const struct strbuf *data);
-__attribute__((format (printf, 4, 5)))
+FORMATPRINTF(4,5)
 extern void trace_performance_fl(const char *file, int line,
 				 uint64_t nanos, const char *fmt, ...);
 
-- 
2.5.0
Previous: Elia PintoNext: Elia Pinto
Message 22 of 28 in “add the FORMATPRINTF macro to declare the gcc function”
  1. 00/22 add the FORMATPRINTF macro to declare the gcc functionElia Pinto, Feb 11, 2016
  2. 01/22 git-compat-util.h: add the FORMATPRINTF macroElia Pinto, Feb 11, 2016
  3. 02/22 advice.h: use the FORMATPRINTF macro to declare the gcc function attribute 'format printf'Elia Pinto, Feb 11, 2016
  4. 03/22 argv-array.h: use the FORMATPRINTF macro to declare the gcc function attribute 'format printf'Elia Pinto, Feb 11, 2016
  5. Junio C HamanoFeb 11, 2016
  6. Junio C HamanoFeb 11, 2016
  7. 04/22 builtin/index-pack.c: use the FORMATPRINTF macro to declare the gcc function attribute 'format printf'Elia Pinto, Feb 11, 2016
  8. 05/22 builtin/receive-pack.c: use the FORMATPRINTF macro to declare the gcc function attribute 'format printf'Elia Pinto, Feb 11, 2016
  9. 06/22 builtin/update-index.c: use the FORMATPRINTF macro to declare the gcc function attribute 'format printf'Elia Pinto, Feb 11, 2016
  10. 07/22 builtin/upload-archive.c: use the FORMATPRINTF macro to declare the gcc function attribute 'format printf'Elia Pinto, Feb 11, 2016
  11. 08/22 cache.h: use the FORMATPRINTF macro to declare the gcc function attribute 'format printf'Elia Pinto, Feb 11, 2016
  12. 09/22 color.h: use the FORMATPRINTF macro to declare the gcc function attribute 'format printf'Elia Pinto, Feb 11, 2016
  13. 10/22 config.c: use the FORMATPRINTF macro to declare the gcc function attribute 'format printf'Elia Pinto, Feb 11, 2016
  14. 11/22 daemon.c: use the FORMATPRINTF macro to declare the gcc function attribute 'format printf'Elia Pinto, Feb 11, 2016
  15. 12/22 fsck.c: use the FORMATPRINTF macro to declare the gcc function attribute 'format printf'Elia Pinto, Feb 11, 2016
  16. 13/22 http-backend.c: use the FORMATPRINTF macro to declare the gcc function attribute 'format printf'Elia Pinto, Feb 11, 2016
  17. 14/22 imap-send.c: use the FORMATPRINTF macro to declare the gcc function attribute 'format printf'Elia Pinto, Feb 11, 2016
  18. 15/22 merge-recursive.c: use the FORMATPRINTF macro to declare the gcc function attribute 'format printf'Elia Pinto, Feb 11, 2016
  19. 16/22 pkt-line.h: use the FORMATPRINTF macro to declare the gcc function attribute 'format printf'Elia Pinto, Feb 11, 2016
  20. 17/22 remote.c: use the FORMATPRINTF macro to declare the gcc function attribute 'format printf'Elia Pinto, Feb 11, 2016
  21. 18/22 strbuf.h: use the FORMATPRINTF macro to declare the gcc function attribute 'format printf'Elia Pinto, Feb 11, 2016
  22. 19/22 trace.h: use the FORMATPRINTF macro to declare the gcc function attribute 'format printf'Elia Pinto, Feb 11, 2016
  23. 20/22 transport-helper.c: use the FORMATPRINTF macro to declare the gcc function attribute 'format printf'Elia Pinto, Feb 11, 2016
  24. 21/22 utf8.h: use the FORMATPRINTF macro to declare the gcc function attribute 'format printf'Elia Pinto, Feb 11, 2016
  25. 22/22 wt-status.h: use the FORMATPRINTF macro to declare the gcc function attribute 'format printf'Elia Pinto, Feb 11, 2016
  26. Junio C HamanoFeb 11, 2016
  27. Jeff KingFeb 11, 2016
  28. Junio C HamanoFeb 18, 2016

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.