Re: [PATCH v2 13/21] refs: resolve symbolic refs first

From: David Turner <dturner@twopensource.com>
Date: Jan 13, 2016, 16:33 UTC
Message-ID: <1452702809.16226.1.camel@twopensource.com>
In-Reply-To: <xmqqmvsaqqk5.fsf@gitster.mtv.corp.google.com>

On Tue, 2016-01-12 at 16:19 -0800, Junio C Hamano wrote:

Show 23 quoted lines

> David Turner <dturner@twopensource.com> writes:
> 
> > +static int dereference_symrefs(struct ref_transaction
> > *transaction,
> > +			       struct strbuf *err)
> > +{
> > +	int i;
> > +	int nr = transaction->nr;
> > +
> > +	for (i = 0; i < nr; i++) {
> > +		struct ref_update *update = transaction
> > ->updates[i];
> > +		const char *resolved;
> > +		unsigned char sha1[20];
> > +		int resolve_flags = 0;
> > +		int mustexist = (update->old_sha1 &&
> > +				 !is_null_sha1(update->old_sha1));
> > +		int deleting = (update->flags & REF_HAVE_NEW) &&
> > +			is_null_sha1(update->new_sha1);
> > +		struct ref_update *new_update;
> 
> This variable is never used (at least at the end of the series after
> applying up to 21/21).

Fixed, thanks.