git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 06/10] t/t7602-merge-octopus-many.sh: use the $( ... ) construct for command substitution

From
Elia Pinto <gitter.spiros@gmail.com>
Date
Jan 8, 2016, 11:06 UTC
Message-ID
<1452251188-12939-7-git-send-email-gitter.spiros@gmail.com>
In-Reply-To
<1452251188-12939-1-git-send-email-gitter.spiros@gmail.com>

The Git CodingGuidelines prefer the $(...) construct for command substitution instead of using the backquotes `...`.

The backquoted form is the traditional method for command substitution, and is supported by POSIX. However, all but the simplest uses become complicated quickly. In particular, embedded command substitutions and/or the use of double quotes require careful escaping with the backslash character.

The patch was generated by:
for _f in $(find . -name "*.sh")
do
	perl -i -pe 'BEGIN{undef $/;} s/`(.+?)`/\$(\1)/smg'  "${_f}"
done
and then carefully proof-read.
Signed-off-by: Elia Pinto <gitter.spiros@gmail.com>
---
 t/t7602-merge-octopus-many.sh | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/t/t7602-merge-octopus-many.sh b/t/t7602-merge-octopus-many.sh
index 955f09f..6abe441 100755
--- a/t/t7602-merge-octopus-many.sh
+++ b/t/t7602-merge-octopus-many.sh
@@ -19,7 +19,7 @@ test_expect_success 'setup' '
 		git add c$i.c &&
 		git commit -m c$i &&
 		git tag c$i &&
-		i=`expr $i + 1` || return 1
+		i=$(expr $i + 1) || return 1
 	done
 '
 
@@ -30,7 +30,7 @@ test_expect_success 'merge c1 with c2, c3, c4, ... c29' '
 	while test $i -le 30
 	do
 		refs="$refs c$i"
-		i=`expr $i + 1`
+		i=$(expr $i + 1)
 	done &&
 	git merge $refs &&
 	test "$(git rev-parse c1)" != "$(git rev-parse HEAD)" &&
@@ -38,14 +38,14 @@ test_expect_success 'merge c1 with c2, c3, c4, ... c29' '
 	while test $i -le 30
 	do
 		test "$(git rev-parse c$i)" = "$(git rev-parse HEAD^$i)" &&
-		i=`expr $i + 1` || return 1
+		i=$(expr $i + 1) || return 1
 	done &&
 	git diff --exit-code &&
 	i=1 &&
 	while test $i -le 30
 	do
 		test -f c$i.c &&
-		i=`expr $i + 1` || return 1
+		i=$(expr $i + 1) || return 1
 	done
 '
 
-- 
2.3.3.GIT
Previous: Elia PintoNext: Elia Pinto
Message 7 of 17 in “use the $( ... ) construct for command substitution”
  1. 00/10 use the $( ... ) construct for command substitutionElia Pinto, Jan 8, 2016
  2. 01/10 t/t7103-reset-bare.sh: use the $( ... ) construct for command substitutionElia Pinto, Jan 8, 2016
  3. 02/10 t/t7406-submodule-update.sh: use the $( ... ) construct for command substitutionElia Pinto, Jan 8, 2016
  4. 03/10 t/t7408-submodule-reference.sh: use the $( ... ) construct for command substitutionElia Pinto, Jan 8, 2016
  5. 04/10 t/t7504-commit-msg-hook.sh: use the $( ... ) construct for command substitutionElia Pinto, Jan 8, 2016
  6. 05/10 t/t7505-prepare-commit-msg-hook.sh: use the $( ... ) construct for command substitutionElia Pinto, Jan 8, 2016
  7. 06/10 t/t7602-merge-octopus-many.sh: use the $( ... ) construct for command substitutionElia Pinto, Jan 8, 2016
  8. 07/10 t/t7700-repack.sh: use the $( ... ) construct for command substitutionElia Pinto, Jan 8, 2016
  9. 08/10 t/t8003-blame-corner-cases.sh: use the $( ... ) construct for command substitutionElia Pinto, Jan 8, 2016
  10. 09/10 t/t9001-send-email.sh: use the $( ... ) construct for command substitutionElia Pinto, Jan 8, 2016
  11. 10/10 t/t9001-send-email.sh: get rid of unnecessary backquotesElia Pinto, Jan 8, 2016
  12. Matthieu MoyJan 8, 2016
  13. Junio C HamanoJan 8, 2016
  14. Elia PintoJan 8, 2016
  15. Junio C HamanoJan 8, 2016
  16. Elia PintoJan 8, 2016
  17. Johannes SixtJan 8, 2016

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.