Re: [PATCH v3] reflog-walk: don't segfault on non-commit sha1's in the reflog

From: Dennis Kaarsemaker <dennis@kaarsemaker.net>
Date: Dec 31, 2015, 15:43 UTC
Message-ID: <1451576580.11138.14.camel@kaarsemaker.net>
In-Reply-To: <1451552227.11138.6.camel@kaarsemaker.net>

On do, 2015-12-31 at 09:57 +0100, Dennis Kaarsemaker wrote:

Show 18 quoted lines

> > > +test_expect_success 'reflog containing non-commit sha1s displays
> > > properly' '
> > 
> > In general, "properly" is a poor word to use in test description
> (or
> > a commit log message or a bug report, for that matter), as the
> whole
> > point of a test is to precisely define what is "proper".
> > 
> > And the code change declares that a proper thing to do is to omit
> > non-commit entries without segfaulting, so something like
> > 
> >     s/displays properly/omits them/
> > 
> > perhaps?
> 
> I did find the test title a bit iffy but couldn't really figure out
> why. What you're saying makes a lot of sense, will fix.

Thinking about it a bit more: 'proper' would be to show everything, we just expect that not to work yet. So I'll make it

test_expect_failure 'reflog with non-commit entries displays all entries' '
	git reflog refs/tests/tree-in-reflog >actual &&
	test_line_count = 3 actual
'

-- 
Dennis Kaarsemaker
www.kaarsemaker.net