git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v2 0/2] do_compare_entry: use already-computed path

From
David Turner <dturner@twopensource.com>
Date
Dec 22, 2015, 04:26 UTC
Message-ID
<1450758362.3892.7.camel@twopensource.com>
In-Reply-To
<CAPc5daW4ru0j4Zd3ynnRcG8df7sZ9ZuVHu8mz2rxVonZpyE4Gw@mail.gmail.com>
On Mon, 2015-12-21 at 15:34 -0800, Junio C Hamano wrote:
Show 9 quoted lines
> Great. Thanks, will queue w/o 1/2 (though I do not think it would
> hurt).
> 
> On Mon, Dec 21, 2015 at 3:33 PM, David Turner <
> dturner@twopensource.com> wrote:
> > On Mon, 2015-12-21 at 15:27 -0800, Junio C Hamano wrote:
> > > Thanks.  Does the number still stay at 25% improvement?
> > 
> > Yes.

BTW, that function, via ce_in_traverse_path, gets called about 40 million times when switching (checking out) between master and a branch that's a few months old (and that contains relatively small changes from master-as-of-then. Our repo only has approximately a quarter -million files. This seems somewhat unreasonable to me, but I haven't really looked into what's going on. Do you happen to know why this is and whether it is likely to be a bug?

Previous: David TurnerNext: Junio C Hamano
Message 8 of 9 in “do_compare_entry: use already-computed path”
  1. 0/2 do_compare_entry: use already-computed pathDavid Turner, Dec 21, 2015
  2. 1/2 traverse_info: make mostly constDavid Turner, Dec 21, 2015
  3. David TurnerDec 21, 2015
  4. 2/2 do_compare_entry: use already-computed pathDavid Turner, Dec 21, 2015
  5. David TurnerJan 5, 2016
  6. Junio C HamanoDec 21, 2015
  7. David TurnerDec 21, 2015
  8. David TurnerDec 22, 2015
  9. Junio C HamanoDec 22, 2015

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.