[PATCH] hooks/update: Add a hooks.denyunsignedtags option
- From
Julian Andres Klode <jak@debian.org>
- Date
- Dec 21, 2015, 17:32 UTC
- Message-ID
- <1450719124-10558-1-git-send-email-jak@debian.org>
Introduce an option to deny unsigned tags from entering a repository. This is useful in teams where members forget to sign their release tags.
It does not actually check whether the signature is actually complete or valid, it just checks for the beginning of a signature, as further checks would be too involved.
This effectively also denies un-annotated tags, as those are unsigned by definition.
Signed-off-by: Julian Andres Klode <jak@debian.org> ---
Note: Submitted for review on Sep 12, re-asked on Sep 22, but no feedback, so I assume it's good to go, see http://thread.gmane.org/gmane.comp.version-control.git/277722 for details
templates/hooks--update.sample | 14 +++++++++++++- 1 file changed, 13 insertions(+), 1 deletion(-)
diff --git a/templates/hooks--update.sample b/templates/hooks--update.sample index d847583..e261d30 100755 --- a/templates/hooks--update.sample +++ b/templates/hooks--update.sample @@ -16,6 +16,9 @@ # hooks.allowmodifytag # This boolean sets whether a tag may be modified after creation. By default # it won't be. +# hooks.denyunsignedtag +# This boolean sets whether creating unsigned tags will be denied. By +# default this is allowed. # hooks.allowdeletebranch # This boolean sets whether deleting branches will be allowed in the # repository. By default they won't be. @@ -48,6 +51,7 @@ allowdeletebranch=$(git config --bool hooks.allowdeletebranch) denycreatebranch=$(git config --bool hooks.denycreatebranch) allowdeletetag=$(git config --bool hooks.allowdeletetag) allowmodifytag=$(git config --bool hooks.allowmodifytag) +denyunsignedtag=$(git config --bool hooks.denyunsignedtag) # check for no description projectdesc=$(sed -e '1q' "$GIT_DIR/description") @@ -71,7 +75,7 @@ case "$refname","$newrev_type" in refs/tags/*,commit) # un-annotated tag short_refname=${refname##refs/tags/} - if [ "$allowunannotated" != "true" ]; then + if [ "$allowunannotated" != "true" ] || [ "$denyunsignedtag" = "true" ]; then echo "*** The un-annotated tag, $short_refname, is not allowed in this repository" >&2 echo "*** Use 'git tag [ -a | -s ]' for tags you want to propagate." >&2 exit 1 @@ -86,6 +90,14 @@ case "$refname","$newrev_type" in ;; refs/tags/*,tag) # annotated tag + if [ "$denyunsignedtag" != "true" ] || git cat-file -p $newrev | grep -q 'BEGIN PGP SIGNATURE'; then + : + else + echo "*** Tag '$refname' is unsigned" + echo "*** Unsigned tags are not allowed in this repository." >&2 + exit 1 + fi + if [ "$allowmodifytag" != "true" ] && git rev-parse $refname > /dev/null 2>&1 then echo "*** Tag '$refname' already exists." >&2
-- 2.6.4