git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 1/2] git-p4: failing test case for skipping changes with multiple depots

From
Luke Diamand <luke@diamand.org>
Date
Dec 13, 2015, 20:07 UTC
Message-ID
<1450037234-15344-2-git-send-email-luke@diamand.org>
In-Reply-To
<1450037234-15344-1-git-send-email-luke@diamand.org>

James Farwell reported that with multiple depots git-p4 would skip changes.

http://article.gmane.org/gmane.comp.version-control.git/282297
Add a failing test case demonstrating the problem.
Signed-off-by: Luke Diamand <luke@diamand.org>
---
 t/t9818-git-p4-block.sh | 28 +++++++++++++++++++++++++++-
 1 file changed, 27 insertions(+), 1 deletion(-)
diff --git a/t/t9818-git-p4-block.sh b/t/t9818-git-p4-block.sh
index 3b3ae1f..64510b7 100755
--- a/t/t9818-git-p4-block.sh
+++ b/t/t9818-git-p4-block.sh
@@ -84,7 +84,7 @@ p4_add_file() {
 	(cd "$cli" &&
 		>$1 &&
 		p4 add $1 &&
-		p4 submit -d "Added a file" $1
+		p4 submit -d "Added file $1" $1
 	)
 }
 
@@ -112,6 +112,32 @@ test_expect_success 'Syncing files' '
 	)
 '
 
+# Handling of multiple depot paths:
+#    git p4 clone //depot/pathA //depot/pathB
+#
+test_expect_success 'Create a repo with multiple depot paths' '
+	client_view "//depot/pathA/... //client/pathA/..." \
+		    "//depot/pathB/... //client/pathB/..." &&
+	mkdir -p "$cli/pathA" "$cli/pathB" &&
+	for p in pathA pathB
+	do
+		for i in $(test_seq 1 10)
+		do
+			p4_add_file "$p/file$p$i"
+		done
+	done
+'
+
+test_expect_failure 'Clone repo with multiple depot paths' '
+	(
+		cd "$git" &&
+		git p4 clone --changes-block-size=4 //depot/pathA@all //depot/pathB@all \
+			--destination=dest &&
+		ls -1 dest >log &&
+		test_line_count = 20 log
+	)
+'
+
 test_expect_success 'kill p4d' '
 	kill_p4d
 '
-- 
2.6.2.474.g3eb3291
Previous: Luke DiamandNext: Luke Diamand
Message 2 of 11 in “git-p4: fix for handling of multiple depot paths”
  1. 0/2 git-p4: fix for handling of multiple depot pathsLuke Diamand, Dec 13, 2015
  2. 1/2 git-p4: failing test case for skipping changes with multiple depotsLuke Diamand, Dec 13, 2015
  3. 2/2 git-p4: fix handling of multiple depot pathsLuke Diamand, Dec 13, 2015
  4. Luke DiamandDec 13, 2015
  5. Junio C HamanoDec 14, 2015
  6. Luke DiamandDec 14, 2015
  7. Junio C HamanoDec 14, 2015
  8. Luke DiamandDec 14, 2015
  9. James FarwellDec 15, 2015
  10. Sam HocevarDec 16, 2015
  11. Luke DiamandDec 16, 2015

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.