git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH v2 3/3] format-patch: check that header line has expected format

From
brian m. carlson <sandals@crustytoothpaste.net>
Date
Dec 13, 2015, 17:27 UTC
Message-ID
<1450027638-788102-4-git-send-email-sandals@crustytoothpaste.net>
In-Reply-To
<1450027638-788102-1-git-send-email-sandals@crustytoothpaste.net>

The format of the "From " header line is very specific to allow utilities to detect Git-style patches. Add a test that the patches created are in the expected format.

Signed-off-by: brian m. carlson <sandals@crustytoothpaste.net>
---
 t/t4014-format-patch.sh | 6 ++++++
 1 file changed, 6 insertions(+)
diff --git a/t/t4014-format-patch.sh b/t/t4014-format-patch.sh
index b740e3da..362bc228 100755
--- a/t/t4014-format-patch.sh
+++ b/t/t4014-format-patch.sh
@@ -1437,4 +1437,10 @@ test_expect_success 'format-patch --zero-commit' '
 	test $cnt = 3
 '
 
+test_expect_success 'From line has expected format' '
+	git format-patch --stdout v2..v1 >patch2 &&
+	cnt=$(egrep "^From [0-9a-f]{40} Mon Sep 17 00:00:00 2001" patch2 | wc -l) &&
+	test $cnt = 3
+'
+
 test_done
Previous: Junio C HamanoNext: Torsten Bögershausen
Message 5 of 10 in “format-patch: introduce option to suppress commit hashes”
  1. 0/3 format-patch: introduce option to suppress commit hashesbrian m. carlson, Dec 13, 2015
  2. 1/3 Introduce a null_oid constant.brian m. carlson, Dec 13, 2015
  3. 2/3 format-patch: add an option to suppress commit hashbrian m. carlson, Dec 13, 2015
  4. Junio C HamanoDec 14, 2015
  5. 3/3 format-patch: check that header line has expected formatbrian m. carlson, Dec 13, 2015
  6. Torsten BögershausenDec 14, 2015
  7. Junio C HamanoDec 14, 2015
  8. Junio C HamanoDec 14, 2015
  9. Jeff KingDec 14, 2015
  10. brian m. carlsonDec 15, 2015

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.