[PATCH v2] revision.c: fix possible null pointer access

From: Stefan Naewe <stefan.naewe@gmail.com>
Date: Dec 5, 2015, 15:27 UTC
Message-ID: <1449329244-4585-1-git-send-email-stefan.naewe@gmail.com>
In-Reply-To: <xmqqlh9bthyb.fsf@gitster.mtv.corp.google.com>

mark_tree_uninteresting dereferences a tree pointer before checking if the pointer is valid. Fix that by doing the check first.

Signed-off-by: Stefan Naewe <stefan.naewe@gmail.com>
---
 revision.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/revision.c b/revision.c
index 0fbb684..8c569cc 100644
--- a/revision.c
+++ b/revision.c
@@ -135,10 +135,12 @@ static void mark_tree_contents_uninteresting(struct tree *tree)
 
 void mark_tree_uninteresting(struct tree *tree)
 {
-	struct object *obj = &tree->object;
+	struct object *obj;
 
 	if (!tree)
 		return;
+
+	obj = &tree->object;
 	if (obj->flags & UNINTERESTING)
 		return;
 	obj->flags |= UNINTERESTING;

-- 
2.6.3