git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCHv5 1/9] run_processes_parallel: delimit intermixed task output

From
Stefan Beller <sbeller@google.com>
Date
Nov 25, 2015, 01:14 UTC
Message-ID
<1448414096-22021-2-git-send-email-sbeller@google.com>
In-Reply-To
<1448414096-22021-1-git-send-email-sbeller@google.com>

This commit serves 2 purposes. First this may help the user who tries to diagnose intermixed process calls. Second this may be used in a later patch for testing. As the output of a command should not change visibly except for going faster, grepping for the trace output seems like a viable testing strategy.

Signed-off-by: Stefan Beller <sbeller@google.com>
---
 run-command.c | 4 ++++
 1 file changed, 4 insertions(+)
diff --git a/run-command.c b/run-command.c
index 358429f..b246118 100644
--- a/run-command.c
+++ b/run-command.c
@@ -965,6 +965,9 @@ static struct parallel_processes *pp_init(int n,
 		n = online_cpus();
 
 	pp->max_processes = n;
+
+	trace_printf("run_processes_parallel: preparing to run up to %d tasks", n);
+
 	pp->data = data;
 	if (!get_next_task)
 		die("BUG: you need to specify a get_next_task function");
@@ -994,6 +997,7 @@ static void pp_cleanup(struct parallel_processes *pp)
 {
 	int i;
 
+	trace_printf("run_processes_parallel: done");
 	for (i = 0; i < pp->max_processes; i++) {
 		strbuf_release(&pp->children[i].err);
 		child_process_clear(&pp->children[i].process);
-- 
2.6.1.261.g0d9c4c1
Previous: Stefan BellerNext: Stefan Beller
Message 2 of 10 in “[PATCHv5 0/9] Expose submodule parallelism to the user”
  1. Stefan BellerNov 25, 2015
  2. 1/9 run_processes_parallel: delimit intermixed task outputStefan Beller, Nov 25, 2015
  3. 2/9 submodule-config: keep update strategy aroundStefan Beller, Nov 25, 2015
  4. 3/9 submodule-config: drop check against NULLStefan Beller, Nov 25, 2015
  5. 4/9 submodule-config: remove name_and_item_from_varStefan Beller, Nov 25, 2015
  6. 5/9 submodule-config: introduce parse_generic_submodule_configStefan Beller, Nov 25, 2015
  7. 6/9 fetching submodules: respect `submodule.fetchJobs` config optionStefan Beller, Nov 25, 2015
  8. 7/9 git submodule update: have a dedicated helper for cloningStefan Beller, Nov 25, 2015
  9. 8/9 submodule update: expose parallelism to the userStefan Beller, Nov 25, 2015
  10. 9/9 clone: allow an explicit argument for parallel submodule clonesStefan Beller, Nov 25, 2015

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.