git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH v2 1/3] git-p4: add failing test for submit from detached head

From
Luke Diamand <luke@diamand.org>
Date
Nov 21, 2015, 09:54 UTC
Message-ID
<1448099681-20183-2-git-send-email-luke@diamand.org>
In-Reply-To
<1448099681-20183-1-git-send-email-luke@diamand.org>

git-p4 can't submit from a detached head. This test case demonstrates the problem.

Signed-off-by: Luke Diamand <luke@diamand.org>
---
 t/t9800-git-p4-basic.sh | 16 ++++++++++++++++
 1 file changed, 16 insertions(+)
diff --git a/t/t9800-git-p4-basic.sh b/t/t9800-git-p4-basic.sh
index 90d41ed..114b19f 100755
--- a/t/t9800-git-p4-basic.sh
+++ b/t/t9800-git-p4-basic.sh
@@ -241,6 +241,22 @@ test_expect_success 'unresolvable host in P4PORT should display error' '
 	)
 '
 
+test_expect_failure 'submit from detached head' '
+	test_when_finished cleanup_git &&
+	git p4 clone --dest="$git" //depot &&
+	(
+		cd "$git" &&
+		git checkout p4/master &&
+		>detached_head_test &&
+		git add detached_head_test &&
+		git commit -m "add detached_head" &&
+		git config git-p4.skipSubmitEdit true &&
+		git p4 submit &&
+		git p4 rebase &&
+		git log p4/master | grep detached_head
+	)
+'
+
 test_expect_success 'kill p4d' '
 	kill_p4d
 '
-- 
2.6.0.rc3.238.gc07a1e8
Previous: Luke DiamandNext: Luke Diamand
Message 2 of 4 in “git-p4: allow submission from detached head”
  1. 0/2 git-p4: allow submission from detached headLuke Diamand, Nov 21, 2015
  2. 1/3 git-p4: add failing test for submit from detached headLuke Diamand, Nov 21, 2015
  3. 2/3 git-p4: add option to system() to return subshell statusLuke Diamand, Nov 21, 2015
  4. 3/3 git-p4: work with a detached headLuke Diamand, Nov 21, 2015

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.