git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [BUG] gitk --all and git bisect visualize crash in non-english locale

From
Dennis Kaarsemaker <dennis@kaarsemaker.net>
Date
Nov 18, 2015, 21:53 UTC
Message-ID
<1447883599.28206.1.camel@kaarsemaker.net>
In-Reply-To
<vpqa8qbrwgc.fsf@anie.imag.fr>
Hi Matthieu,

This has been reported quite a few times before. A fix is in master, see 482456a^2 and children.

On wo, 2015-11-18 at 19:31 +0100, Matthieu Moy wrote:
Show 57 quoted lines
> Hi,
> 
> I'm getting the following crash on recent gitk:
> 
>   $ LANG=fr_FR gitk --all
>   Error in startup script: bad menu entry index "Éditer la vue..."
>       while executing
>   ".bar.view entryconf [mca "Edit view..."] -state normal"
>       invoked from within
>   "if {$cmdline_files ne {} || $revtreeargs ne {} || $revtreeargscmd
> ne {}} {
>       # create a view for the files/dirs specified on the command
> line
>       se..."
>       (file "/home/moy/local/usr-jessie/bin/gitk" line 12442)
> 
> It's linked to the locale:
> 
>   $ LANG=C gitk --all
>   # Just works
> 
> but does not seem to be related to French in particular nor to the
> accent:
> 
>   $ LANG=es_ES gitk --all
>   Error in startup script: bad menu entry index "Modificar vista..."
>       while executing
>   ".bar.view entryconf [mca "Edit view..."] -state normal"
>       invoked from within
>   "if {$cmdline_files ne {} || $revtreeargs ne {} || $revtreeargscmd
> ne {}} {
>       # create a view for the files/dirs specified on the command
> line
>       se..."
>       (file "/home/moy/local/usr-jessie/bin/gitk" line 12442)
> 
> It also works fine without --all.
> 
> It bisects down to:
> 
> commit d99b4b0de27a2bd654a40353b65883e368da6d06
> Author: Giuseppe Bilotta <giuseppe.bilotta@gmail.com>
> Date:   Wed Sep 9 15:20:53 2015 +0200
> 
>     gitk: Accelerators for the main menu
>     
>     This allows fast, keyboard-only usage of the menu (e.g. Alt+V, N
> to open a
>     new view).
>     
>     Signed-off-by: Giuseppe Bilotta <giuseppe.bilotta@gmail.com>
>     Signed-off-by: Paul Mackerras <paulus@samba.org>
> 
> I'm not fluent enough in Tcl to fix this myself, sorry ;-).
> 
> Thanks,
> 
-- 
Dennis Kaarsemaker
www.kaarsemaker.net
Previous: Matthieu MoyNext: Matthieu Moy
Message 2 of 3 in “[BUG] gitk --all and git bisect visualize crash in non-english locale”
  1. Matthieu MoyNov 18, 2015
  2. Dennis KaarsemakerNov 18, 2015
  3. Matthieu MoyNov 20, 2015

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.