git/list[1] front-page[2] threads[3] people[4] search[5] about
 

verify_pack ignores return value of verify_fn

From
David Turner <dturner@twopensource.com>
Date
Nov 18, 2015, 00:31 UTC
Message-ID
<1447806715.5082.11.camel@twopensource.com>

In pack-check.c, line 129, a caller-supplied verification function is called. The function returns an int, but that return value is ignored.

The only caller of verify_pack is in builtin/fsck.c, whose verify_fn *does* return a meaningful error code (which is then ignored). If it were not ignored, fsck might return a different error code (in the unlikely event that a weird object gets into a pack and is somehow not totally corrupt enough to fail an earlier check).

I think we should probably have verify_pack return a non-zero result if any call to verify_fn returns a non-zero result. Any objections to this?

Next: Jeff King
Message 1 of 2 in “verify_pack ignores return value of verify_fn”
  1. David TurnerNov 18, 2015
  2. Jeff KingNov 24, 2015

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.