git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH] Makefile: use SHELL_PATH when running generate-cmdlist.sh

From
Alejandro R. Sedeño <asedeno@mit.edu>
Date
Sep 10, 2015, 23:37 UTC
Message-ID
<1441928227-830-1-git-send-email-asedeno@mit.edu>

Some /bin/sh implementations can't deal with $() arithmetic and command substitution. If we already have a better shell on hand, we should use it.

Fixes the build on SunOS, probably others.
Signed-off-by: Alejandro R. Sedeño <asedeno@mit.edu>
---
 Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Makefile b/Makefile
index ce0cfe2..6301cc8 100644
--- a/Makefile
+++ b/Makefile
@@ -1699,7 +1699,7 @@ $(BUILT_INS): git$X
 common-cmds.h: generate-cmdlist.sh command-list.txt
 
 common-cmds.h: $(wildcard Documentation/git-*.txt)
-	$(QUIET_GEN)./generate-cmdlist.sh command-list.txt >$@+ && mv $@+ $@
+	$(QUIET_GEN)$(SHELL_PATH) ./generate-cmdlist.sh command-list.txt >$@+ && mv $@+ $@
 
 SCRIPT_DEFINES = $(SHELL_PATH_SQ):$(DIFF_SQ):$(GIT_VERSION):\
 	$(localedir_SQ):$(NO_CURL):$(USE_GETTEXT_SCHEME):$(SANE_TOOL_PATH_SQ):\
-- 
2.5.2
Next: Eric Sunshine
Message 1 of 2 in “Makefile: use SHELL_PATH when running generate-cmdlist.sh”
  1. Makefile: use SHELL_PATH when running generate-cmdlist.shAlejandro R. Sedeño, Sep 10, 2015
  2. Eric SunshineSep 11, 2015

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.