git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Bug? push --recurse-submodules=on-demandd not really recursive

From
PRPedro Rodrigues <prodrigues1990@gmail.com>
Date
Sep 5, 2015, 08:31 UTC
Message-ID
<1441441863.2246.0@smtp.gmail.com>

Yesterday I was discussing this in on G+, which lead me to conclude this is actually a bug (or, at least, a very good improvement).

When you run push --recurse-submodules=on-demand, according to the push manpage you would expect any submodule commit missing on it's default remote to be pushed aswell. But this only works for the submodules of the repo you run it in, it does not work in nested submodules (hence not being recursive at all).

I could (with my very little understanding of C) confirm this in the source code, and the boils down to the function push_submodule on file transport.c explicitly calling push without any params, where I would expect it to call with --recurse-submodules=on-demand when done so on the parent repo (and then it will actually be trully recursive).

Any thoughts?
Message 1 of 1 in “Bug? push --recurse-submodules=on-demandd not really recursive”
  1. Pedro RodriguesSep 5, 2015

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.