git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH v2 5/9] transport: Remove git_transport_options.push_cert

From
Dave Borowitz <dborowitz@google.com>
Date
Aug 19, 2015, 15:26 UTC
Message-ID
<1439998007-28719-6-git-send-email-dborowitz@google.com>
In-Reply-To
<1439998007-28719-1-git-send-email-dborowitz@google.com>

This field was set in transport_set_option, but never read in the push code. The push code basically ignores the smart_options field entirely, and derives its options from the flags arguments to the push* callbacks. Note that in git_transport_push there are already several args set from flags that have no corresponding field in git_transport_options; after this change, push_cert is just like those.

Signed-off-by: Dave Borowitz <dborowitz@google.com>
---
 transport.c | 3 ---
 transport.h | 1 -
 2 files changed, 4 deletions(-)
diff --git a/transport.c b/transport.c
index 40692f8..3dd6e30 100644
--- a/transport.c
+++ b/transport.c
@@ -476,9 +476,6 @@ static int set_git_option(struct git_transport_options *opts,
 				die("transport: invalid depth option '%s'", value);
 		}
 		return 0;
-	} else if (!strcmp(name, TRANS_OPT_PUSH_CERT)) {
-		opts->push_cert = !!value;
-		return 0;
 	}
 	return 1;
 }
diff --git a/transport.h b/transport.h
index 18d2cf8..79190df 100644
--- a/transport.h
+++ b/transport.h
@@ -12,7 +12,6 @@ struct git_transport_options {
 	unsigned check_self_contained_and_connected : 1;
 	unsigned self_contained_and_connected : 1;
 	unsigned update_shallow : 1;
-	unsigned push_cert : 1;
 	int depth;
 	const char *uploadpack;
 	const char *receivepack;
-- 
2.5.0.276.gf5e568e
Previous: Dave BorowitzNext: Dave Borowitz
Message 10 of 19 in “Flags and config to sign pushes by default”
  1. 0/9 Flags and config to sign pushes by defaultDave Borowitz, Aug 19, 2015
  2. 1/9 Documentation/git-push.txt: Document when --signed may failDave Borowitz, Aug 19, 2015
  3. 2/9 Documentation/git-send-pack.txt: Flow long synopsis lineDave Borowitz, Aug 19, 2015
  4. Junio C HamanoAug 19, 2015
  5. Dave BorowitzAug 19, 2015
  6. Junio C HamanoAug 19, 2015
  7. Junio C HamanoSep 11, 2015
  8. 3/9 Documentation/git-send-pack.txt: Document --signedDave Borowitz, Aug 19, 2015
  9. 4/9 gitremote-helpers.txt: Document pushcert optionDave Borowitz, Aug 19, 2015
  10. 5/9 transport: Remove git_transport_options.push_certDave Borowitz, Aug 19, 2015
  11. 6/9 config.c: Expose git_parse_maybe_boolDave Borowitz, Aug 19, 2015
  12. 7/9 builtin/send-pack.c: Use option parsing APIDave Borowitz, Aug 19, 2015
  13. Stefan BellerAug 19, 2015
  14. Dave BorowitzAug 19, 2015
  15. Jeff KingAug 21, 2015
  16. 8/9 Support signing pushes iff the server supports itDave Borowitz, Aug 19, 2015
  17. Junio C HamanoAug 19, 2015
  18. Dave BorowitzAug 19, 2015
  19. 9/9 Add a config option push.gpgSign for default signed pushesDave Borowitz, Aug 19, 2015

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.