[PATCH v7 23/45] builtin-am: handle stray state directory
- From
Paul Tan <pyokagan@gmail.com>
- Date
- Aug 4, 2015, 13:51 UTC
- Message-ID
- <1438696326-19590-24-git-send-email-pyokagan@gmail.com>
- In-Reply-To
- <1438696326-19590-1-git-send-email-pyokagan@gmail.com>
Should git-am terminate unexpectedly between the point where the state directory is created, but the "next" and "last" files are not written yet, a stray state directory will be left behind.
As such, since b141f3c (am: handle stray $dotest directory, 2013-06-15), git-am.sh explicitly recognizes such a stray directory, and allows the user to remove it with am --abort.
Re-implement this feature in builtin/am.c.
Signed-off-by: Paul Tan <pyokagan@gmail.com> --- builtin/am.c | 17 +++++++++++++++++ 1 file changed, 17 insertions(+)
diff --git a/builtin/am.c b/builtin/am.c index a02c84e..47dd4c7 100644 --- a/builtin/am.c +++ b/builtin/am.c @@ -1530,6 +1530,23 @@ int cmd_am(int argc, const char **argv, const char *prefix) struct argv_array paths = ARGV_ARRAY_INIT; int i; + /* + * Handle stray state directory in the independent-run case. In + * the --rebasing case, it is up to the caller to take care of + * stray directories. + */ + if (file_exists(state.dir) && !state.rebasing) { + if (resume == RESUME_ABORT) { + am_destroy(&state); + am_state_release(&state); + return 0; + } + + die(_("Stray %s directory found.\n" + "Use \"git am --abort\" to remove it."), + state.dir); + } + if (resume) die(_("Resolve operation not in progress, we are not resuming."));
-- 2.5.0.280.gd88bd6e