[PATCH v6 24/45] builtin-am: implement -u/--utf8
- From
Paul Tan <pyokagan@gmail.com>
- Date
- Jul 19, 2015, 16:10 UTC
- Message-ID
- <1437322237-29863-25-git-send-email-pyokagan@gmail.com>
- In-Reply-To
- <1437322237-29863-1-git-send-email-pyokagan@gmail.com>
Since d1c5f2a (Add git-am, applymbox replacement., 2005-10-07), git-am.sh supported the -u,--utf8 option. If set, the -u option will be passed to git-mailinfo to re-code the commit log message and authorship in the charset specified by i18n.commitencoding. If unset, the -n option will be passed to git-mailinfo, which disables the re-encoding.
Since d84029b (--utf8 is now default for 'git-am', 2007-01-08), --utf8 is specified by default in git-am.sh.
Re-implement the above in builtin/am.c.
Signed-off-by: Paul Tan <pyokagan@gmail.com> --- builtin/am.c | 11 +++++++++++ 1 file changed, 11 insertions(+)
diff --git a/builtin/am.c b/builtin/am.c index 398debf..a64a859 100644 --- a/builtin/am.c +++ b/builtin/am.c @@ -90,6 +90,7 @@ struct am_state { int threeway; int quiet; int append_signoff; + int utf8; const char *resolvemsg; int rebasing; }; @@ -108,6 +109,8 @@ static void am_state_init(struct am_state *state, const char *dir) state->prec = 4; git_config_get_bool("am.threeway", &state->threeway); + + state->utf8 = 1; } /** @@ -369,6 +372,9 @@ static void am_load(struct am_state *state) read_state_file(&sb, state, "sign", 1); state->append_signoff = !strcmp(sb.buf, "t"); + read_state_file(&sb, state, "utf8", 1); + state->utf8 = !strcmp(sb.buf, "t"); + state->rebasing = !!file_exists(am_path(state, "rebasing")); strbuf_release(&sb); @@ -558,6 +564,8 @@ static void am_setup(struct am_state *state, enum patch_format patch_format, write_file(am_path(state, "sign"), 1, state->append_signoff ? "t" : "f"); + write_file(am_path(state, "utf8"), 1, state->utf8 ? "t" : "f"); + if (state->rebasing) write_file(am_path(state, "rebasing"), 1, "%s", ""); else @@ -724,6 +732,7 @@ static int parse_mail(struct am_state *state, const char *mail) cp.out = xopen(am_path(state, "info"), O_WRONLY | O_CREAT, 0777); argv_array_push(&cp.args, "mailinfo"); + argv_array_push(&cp.args, state->utf8 ? "-u" : "-n"); argv_array_push(&cp.args, am_path(state, "msg")); argv_array_push(&cp.args, am_path(state, "patch")); @@ -1461,6 +1470,8 @@ int cmd_am(int argc, const char **argv, const char *prefix) OPT__QUIET(&state.quiet, N_("be quiet")), OPT_BOOL('s', "signoff", &state.append_signoff, N_("add a Signed-off-by line to the commit message")), + OPT_BOOL('u', "utf8", &state.utf8, + N_("recode into utf8 (default)")), OPT_CALLBACK(0, "patch-format", &patch_format, N_("format"), N_("format the patch(es) are in"), parse_opt_patchformat),
-- 2.5.0.rc2.110.gb39b692