git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH v7 08/11] parse-option: rename parse_opt_with_commit()

From
Karthik Nayak <karthik.188@gmail.com>
Date
Jul 2, 2015, 15:21 UTC
Message-ID
<1435850470-5175-8-git-send-email-karthik.188@gmail.com>
In-Reply-To
<1435850470-5175-1-git-send-email-karthik.188@gmail.com>

Rename parse_opt_with_commit() to parse_opt_commits() to show that it can be used to obtain a list of commits and is not constricted to usage of '--contains' option.

Mentored-by: Christian Couder <christian.couder@gmail.com>
Mentored-by: Matthieu Moy <matthieu.moy@grenoble-inp.fr>
Signed-off-by: Karthik Nayak <karthik.188@gmail.com>
---
 builtin/branch.c   | 4 ++--
 builtin/tag.c      | 4 ++--
 parse-options-cb.c | 2 +-
 parse-options.h    | 2 +-
 4 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/builtin/branch.c b/builtin/branch.c
index e63102e..ae9a0eb 100644
--- a/builtin/branch.c
+++ b/builtin/branch.c
@@ -832,13 +832,13 @@ int cmd_branch(int argc, const char **argv, const char *prefix)
 			OPTION_CALLBACK, 0, "contains", &with_commit, N_("commit"),
 			N_("print only branches that contain the commit"),
 			PARSE_OPT_LASTARG_DEFAULT,
-			parse_opt_with_commit, (intptr_t)"HEAD",
+			parse_opt_commits, (intptr_t)"HEAD",
 		},
 		{
 			OPTION_CALLBACK, 0, "with", &with_commit, N_("commit"),
 			N_("print only branches that contain the commit"),
 			PARSE_OPT_HIDDEN | PARSE_OPT_LASTARG_DEFAULT,
-			parse_opt_with_commit, (intptr_t) "HEAD",
+			parse_opt_commits, (intptr_t) "HEAD",
 		},
 		OPT__ABBREV(&abbrev),
 
diff --git a/builtin/tag.c b/builtin/tag.c
index 280981f..7af45a0 100644
--- a/builtin/tag.c
+++ b/builtin/tag.c
@@ -603,13 +603,13 @@ int cmd_tag(int argc, const char **argv, const char *prefix)
 			OPTION_CALLBACK, 0, "contains", &with_commit, N_("commit"),
 			N_("print only tags that contain the commit"),
 			PARSE_OPT_LASTARG_DEFAULT,
-			parse_opt_with_commit, (intptr_t)"HEAD",
+			parse_opt_commits, (intptr_t)"HEAD",
 		},
 		{
 			OPTION_CALLBACK, 0, "with", &with_commit, N_("commit"),
 			N_("print only tags that contain the commit"),
 			PARSE_OPT_HIDDEN | PARSE_OPT_LASTARG_DEFAULT,
-			parse_opt_with_commit, (intptr_t)"HEAD",
+			parse_opt_commits, (intptr_t)"HEAD",
 		},
 		{
 			OPTION_CALLBACK, 0, "points-at", &points_at, N_("object"),
diff --git a/parse-options-cb.c b/parse-options-cb.c
index de75411..632f10f 100644
--- a/parse-options-cb.c
+++ b/parse-options-cb.c
@@ -77,7 +77,7 @@ int parse_opt_verbosity_cb(const struct option *opt, const char *arg,
 	return 0;
 }
 
-int parse_opt_with_commit(const struct option *opt, const char *arg, int unset)
+int parse_opt_commits(const struct option *opt, const char *arg, int unset)
 {
 	unsigned char sha1[20];
 	struct commit *commit;
diff --git a/parse-options.h b/parse-options.h
index 1478818..583690c 100644
--- a/parse-options.h
+++ b/parse-options.h
@@ -224,7 +224,7 @@ extern int parse_opt_expiry_date_cb(const struct option *, const char *, int);
 extern int parse_opt_color_flag_cb(const struct option *, const char *, int);
 extern int parse_opt_verbosity_cb(const struct option *, const char *, int);
 extern int parse_opt_object_name(const struct option *, const char *, int);
-extern int parse_opt_with_commit(const struct option *, const char *, int);
+extern int parse_opt_commits(const struct option *, const char *, int);
 extern int parse_opt_tertiary(const struct option *, const char *, int);
 extern int parse_opt_string_list(const struct option *, const char *, int);
 extern int parse_opt_noop_cb(const struct option *, const char *, int);

-- 
2.4.4
Previous: Karthik NayakNext: Karthik Nayak
Message 13 of 20 in “add options to for-each-ref”
  1. 00/11 add options to for-each-refKarthik Nayak, Jul 2, 2015
  2. 01/11 t6302: for-each-ref tests for ref-filter APIsKarthik Nayak, Jul 2, 2015
  3. 02/11 tag: libify parse_opt_points_at()Karthik Nayak, Jul 2, 2015
  4. 03/11 ref-filter: implement '--points-at' optionKarthik Nayak, Jul 2, 2015
  5. 04/11 for-each-ref: add '--points-at' optionKarthik Nayak, Jul 2, 2015
  6. Matthieu MoyJul 2, 2015
  7. Karthik NayakJul 5, 2015
  8. 05/11 ref-filter: add parse_opt_merge_filter()Karthik Nayak, Jul 2, 2015
  9. Matthieu MoyJul 2, 2015
  10. Karthik NayakJul 2, 2015
  11. 06/11 ref-filter: implement '--merged' and '--no-merged' optionsKarthik Nayak, Jul 2, 2015
  12. 07/11 for-each-ref: add '--merged' and '--no-merged' optionsKarthik Nayak, Jul 2, 2015
  13. 08/11 parse-option: rename parse_opt_with_commit()Karthik Nayak, Jul 2, 2015
  14. 09/11 parse-options.h: add macros for '--contains' optionKarthik Nayak, Jul 2, 2015
  15. Matthieu MoyJul 2, 2015
  16. Karthik NayakJul 2, 2015
  17. 10/11 ref-filter: implement '--contains' optionKarthik Nayak, Jul 2, 2015
  18. Matthieu MoyJul 2, 2015
  19. Karthik NayakJul 2, 2015
  20. 11/11 for-each-ref: add '--contains' optionKarthik Nayak, Jul 2, 2015

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.