git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH v11 00/10] bisect terms

From
Matthieu Moy <matthieu.moy@imag.fr>
Date
Jun 29, 2015, 15:40 UTC
Message-ID
<1435592435-27914-1-git-send-email-Matthieu.Moy@imag.fr>
Hi,
So, here's a reroll that tries to address the ongoing discussion.

The first patches are preparatory steps, which are IMHO good regardless of the features. I kept the user-interface to chose terms at the end, and tried to keep the UI patches as small as possible.

I have the feeling that "bisect: add the terms old/new" should be dropped, but I have no strong opinion on that. If you like the feature, say so. If you think the feature doesn't bring enough, and should eventually be obsoleted by "guess which commit is old and which is new", say so too.

The beginning of the series didn't change much since v10. The major change is that I gave up using "git bisect terms <foo> <bar>", and implemented the same feature in "git bisect start". We're losing the ability to run "git bisect terms" several times to change the terms before we use them, but I'm not sure this was a useful feature. OTOH, we're back to the principle "git bisect start" starts from a fresh state, this avoids confusing the situation where the user has leftover from yesterday's "git bisect terms". And the code is much, much simpler.

Antoine Delaite (4):
  bisect: correction of typo
  bisect: replace hardcoded "bad|good" by variables
  bisect: simplify the addition of new bisect terms
  bisect: add the terms old/new
Matthieu Moy (5):
  Documentation/bisect: move getting help section to the end
  bisect: don't mix option parsing and non-trivial code
  bisect: sanity check on terms
  bisect: add 'git bisect terms' to view the current terms
  bisect: allow setting any user-specified in 'git bisect start'
Michael Haggerty (1):
  Documentation/bisect: revise overall content
 Documentation/git-bisect.txt | 236 ++++++++++++++++++++++++++++-----------
 bisect.c                     |  94 ++++++++++++----
 git-bisect.sh                | 255 +++++++++++++++++++++++++++++++++++--------
 revision.c                   |  19 +++-
 t/t6030-bisect-porcelain.sh  | 137 ++++++++++++++++++++++-
 5 files changed, 612 insertions(+), 129 deletions(-)
-- 
2.5.0.rc0.10.gd2bff5d
Next: Matthieu Moy
Message 1 of 15 in “bisect terms”
  1. 00/10 bisect termsMatthieu Moy, Jun 29, 2015
  2. 01/10 bisect: correction of typoMatthieu Moy, Jun 29, 2015
  3. 02/10 Documentation/bisect: move getting help section to the endMatthieu Moy, Jun 29, 2015
  4. 03/10 Documentation/bisect: revise overall contentMatthieu Moy, Jun 29, 2015
  5. 04/10 bisect: replace hardcoded "bad|good" by variablesMatthieu Moy, Jun 29, 2015
  6. 05/10 bisect: simplify the addition of new bisect termsMatthieu Moy, Jun 29, 2015
  7. 06/10 bisect: don't mix option parsing and non-trivial codeMatthieu Moy, Jun 29, 2015
  8. Junio C HamanoJun 29, 2015
  9. Matthieu MoyJun 30, 2015
  10. Junio C HamanoJun 30, 2015
  11. 07/10 bisect: sanity check on termsMatthieu Moy, Jun 29, 2015
  12. 08/10 bisect: add the terms old/newMatthieu Moy, Jun 29, 2015
  13. 09/10 bisect: add 'git bisect terms' to view the current termsMatthieu Moy, Jun 29, 2015
  14. 10/10 bisect: allow setting any user-specified in 'git bisect start'Matthieu Moy, Jun 29, 2015
  15. Junio C HamanoJun 29, 2015

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.