git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 4/6] refs: replace log_ref_write with create_reflog

From
David Turner <dturner@twopensource.com>
Date
Jun 24, 2015, 19:16 UTC
Message-ID
<1435173388-8346-5-git-send-email-dturner@twopensource.com>
In-Reply-To
<1435173388-8346-1-git-send-email-dturner@twopensource.com>

In a moment, we will use this to add reflog creation commands to git-reflog.

Signed-off-by: David Turner <dturner@twopensource.com>
---
 builtin/checkout.c | 2 +-
 refs.c             | 4 ++--
 refs.h             | 2 +-
 3 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/builtin/checkout.c b/builtin/checkout.c
index ac4d10a..7549ae2 100644
--- a/builtin/checkout.c
+++ b/builtin/checkout.c
@@ -629,7 +629,7 @@ static void update_refs_for_switch(const struct checkout_opts *opts,
 				ref_name = mkpath("refs/heads/%s", opts->new_orphan_branch);
 				temp = log_all_ref_updates;
 				log_all_ref_updates = 1;
-				ret = log_ref_setup(ref_name, &log_file, &err);
+				ret = create_reflog(ref_name, &log_file, &err);
 				log_all_ref_updates = temp;
 				strbuf_release(&log_file);
 				if (ret) {
diff --git a/refs.c b/refs.c
index c1a563f..93412ee 100644
--- a/refs.c
+++ b/refs.c
@@ -3119,7 +3119,7 @@ static int copy_msg(char *buf, const char *msg)
 }
 
 /* This function will fill in *err and return -1 on failure */
-int log_ref_setup(const char *refname, struct strbuf *sb_logfile, struct strbuf *err)
+int create_reflog(const char *refname, struct strbuf *sb_logfile, struct strbuf *err)
 {
 	int logfd, oflags = O_APPEND | O_WRONLY;
 	char *logfile;
@@ -3203,7 +3203,7 @@ static int log_ref_write_1(const char *refname, const unsigned char *old_sha1,
 	if (log_all_ref_updates < 0)
 		log_all_ref_updates = !is_bare_repository();
 
-	result = log_ref_setup(refname, sb_log_file, err);
+	result = create_reflog(refname, sb_log_file, err);
 
 	if (result)
 		return result;
diff --git a/refs.h b/refs.h
index eee99f6..d4f75a9 100644
--- a/refs.h
+++ b/refs.h
@@ -233,7 +233,7 @@ int pack_refs(unsigned int flags);
 /*
  * Setup reflog before using. Fill in err and return -1 on failure.
  */
-int log_ref_setup(const char *refname, struct strbuf *logfile, struct strbuf *err);
+int create_reflog(const char *refname, struct strbuf *logfile, struct strbuf *err);
 
 /** Reads log for the value of ref during at_time. **/
 extern int read_ref_at(const char *refname, unsigned int flags,
-- 
2.0.4.314.gdbf7a51-twtrsrc
Previous: David TurnerNext: Junio C Hamano
Message 9 of 16 in “refs backend preamble”
  1. 0/6 refs backend preambleDavid Turner, Jun 24, 2015
  2. 1/6 refs.c: add an err argument to log_ref_setupDavid Turner, Jun 24, 2015
  3. Junio C HamanoJun 25, 2015
  4. 2/6 cherry-pick: Use refs infrastructure for CHERRY_PICK_HEADDavid Turner, Jun 24, 2015
  5. Junio C HamanoJun 25, 2015
  6. 3/6 bisect: use refs infrastructure for BISECT_STARTDavid Turner, Jun 24, 2015
  7. Junio C HamanoJun 25, 2015
  8. David TurnerJun 25, 2015
  9. 4/6 refs: replace log_ref_write with create_reflogDavid Turner, Jun 24, 2015
  10. Junio C HamanoJun 25, 2015
  11. 5/6 git-reflog: add create and exists functionsDavid Turner, Jun 24, 2015
  12. Junio C HamanoJun 25, 2015
  13. Junio C HamanoJun 25, 2015
  14. David TurnerJun 25, 2015
  15. 6/6 git-stash: use git-reflog instead of creating filesDavid Turner, Jun 24, 2015
  16. Junio C HamanoJun 25, 2015

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.