git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH v4 12/19] pull: fast-forward working tree if head is updated

From
Paul Tan <pyokagan@gmail.com>
Date
Jun 18, 2015, 10:54 UTC
Message-ID
<1434624852-6869-13-git-send-email-pyokagan@gmail.com>
In-Reply-To
<1434624852-6869-1-git-send-email-pyokagan@gmail.com>

Since b10ac50 (Fix pulling into the same branch., 2005-08-25), git-pull, upon detecting that git-fetch updated the current head, will fast-forward the working tree to the updated head commit.

Re-implement this behavior.
Signed-off-by: Paul Tan <pyokagan@gmail.com>
---
 builtin/pull.c | 30 ++++++++++++++++++++++++++++++
 1 file changed, 30 insertions(+)
diff --git a/builtin/pull.c b/builtin/pull.c
index 1e688be..110e719 100644
--- a/builtin/pull.c
+++ b/builtin/pull.c
@@ -412,6 +412,7 @@ int cmd_pull(int argc, const char **argv, const char *prefix)
 {
 	const char *repo, **refspecs;
 	struct sha1_array merge_heads = SHA1_ARRAY_INIT;
+	unsigned char orig_head[GIT_SHA1_RAWSZ], curr_head[GIT_SHA1_RAWSZ];
 
 	if (!getenv("_GIT_USE_BUILTIN_PULL")) {
 		const char *path = mkpath("%s/git-pull", git_exec_path());
@@ -435,12 +436,41 @@ int cmd_pull(int argc, const char **argv, const char *prefix)
 	if (file_exists(git_path("MERGE_HEAD")))
 		die_conclude_merge();
 
+	if (get_sha1("HEAD", orig_head))
+		hashclr(orig_head);
+
 	if (run_fetch(repo, refspecs))
 		return 1;
 
 	if (opt_dry_run)
 		return 0;
 
+	if (get_sha1("HEAD", curr_head))
+		hashclr(curr_head);
+
+	if (!is_null_sha1(orig_head) && !is_null_sha1(curr_head) &&
+			hashcmp(orig_head, curr_head)) {
+		/*
+		 * The fetch involved updating the current branch.
+		 *
+		 * The working tree and the index file are still based on
+		 * orig_head commit, but we are merging into curr_head.
+		 * Update the working tree to match curr_head.
+		 */
+
+		warning(_("fetch updated the current branch head.\n"
+			"fast-forwarding your working tree from\n"
+			"commit %s."), sha1_to_hex(orig_head));
+
+		if (checkout_fast_forward(orig_head, curr_head, 0))
+			die(_("Cannot fast-forward your working tree.\n"
+				"After making sure that you saved anything precious from\n"
+				"$ git diff %s\n"
+				"output, run\n"
+				"$ git reset --hard\n"
+				"to recover."), sha1_to_hex(orig_head));
+	}
+
 	get_merge_heads(&merge_heads);
 
 	if (!merge_heads.nr)
-- 
2.1.4
Previous: Paul TanNext: Paul Tan
Message 13 of 22 in “Make git-pull a builtin”
  1. 00/19 Make git-pull a builtinPaul Tan, Jun 18, 2015
  2. 01/19 parse-options-cb: implement parse_opt_passthru()Paul Tan, Jun 18, 2015
  3. 02/19 parse-options-cb: implement parse_opt_passthru_argv()Paul Tan, Jun 18, 2015
  4. 03/19 argv-array: implement argv_array_pushv()Paul Tan, Jun 18, 2015
  5. 04/19 pull: implement skeletal builtin pullPaul Tan, Jun 18, 2015
  6. 05/19 pull: implement fetch + mergePaul Tan, Jun 18, 2015
  7. 06/19 pull: pass verbosity, --progress flags to fetch and mergePaul Tan, Jun 18, 2015
  8. 07/19 pull: pass git-merge's options to git-mergePaul Tan, Jun 18, 2015
  9. 08/19 pull: pass git-fetch's options to git-fetchPaul Tan, Jun 18, 2015
  10. 09/19 pull: error on no merge candidatesPaul Tan, Jun 18, 2015
  11. 10/19 pull: support pull.ff configPaul Tan, Jun 18, 2015
  12. 11/19 pull: check if in unresolved merge statePaul Tan, Jun 18, 2015
  13. 12/19 pull: fast-forward working tree if head is updatedPaul Tan, Jun 18, 2015
  14. 13/19 pull: implement pulling into an unborn branchPaul Tan, Jun 18, 2015
  15. 14/19 pull: set reflog messagePaul Tan, Jun 18, 2015
  16. 15/19 pull: teach git pull about --rebasePaul Tan, Jun 18, 2015
  17. 16/19 pull: configure --rebase via branch.<name>.rebase or pull.rebasePaul Tan, Jun 18, 2015
  18. 17/19 pull --rebase: exit early when the working directory is dirtyPaul Tan, Jun 18, 2015
  19. 18/19 pull --rebase: error on no merge candidate casesPaul Tan, Jun 18, 2015
  20. 19/19 pull: remove redirection to git-pull.shPaul Tan, Jun 18, 2015
  21. Junio C HamanoJun 18, 2015
  22. Paul TanJun 19, 2015

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.