git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH v2 5/5] am: teach mercurial patch parser how to read from stdin

From
Paul Tan <pyokagan@gmail.com>
Date
Jun 15, 2015, 11:08 UTC
Message-ID
<1434366493-27155-6-git-send-email-pyokagan@gmail.com>
In-Reply-To
<1434366493-27155-1-git-send-email-pyokagan@gmail.com>

git-mailsplit, which splits mbox patches, will read the patch from stdin when the filename is "-" or there are no files listed on the command-line.

To be consistent with this behavior, teach the mercurial patch parser to read from stdin if the filename is "-" or no files are listed on the command-line.

Based-on-patch-by: Chris Packham <judge.packham@gmail.com>
Helped-by: Junio C Hamano <gitster@pobox.com>
Signed-off-by: Paul Tan <pyokagan@gmail.com>
---
Notes:
    v2
    
    * Pass the filename directly to perl instead.
 git-am.sh     |  3 ++-
 t/t4150-am.sh | 10 ++++++++++
 2 files changed, 12 insertions(+), 1 deletion(-)
diff --git a/git-am.sh b/git-am.sh
index f0b6c16..a8d33ef 100755
--- a/git-am.sh
+++ b/git-am.sh
@@ -327,6 +327,7 @@ split_patches () {
 		;;
 	hg)
 		this=0
+		test 0 -eq "$#" && set -- -
 		for hg in "$@"
 		do
 			this=$(( $this + 1 ))
@@ -353,7 +354,7 @@ split_patches () {
 					print "\n", $_ ;
 					$subject = 1;
 				}
-			' <"$hg" >"$dotest/$msgnum" || clean_abort
+			' -- "$hg" >"$dotest/$msgnum" || clean_abort
 		done
 		echo "$this" >"$dotest/last"
 		this=
diff --git a/t/t4150-am.sh b/t/t4150-am.sh
index 4beb4b3..3ebafd9 100755
--- a/t/t4150-am.sh
+++ b/t/t4150-am.sh
@@ -259,6 +259,16 @@ test_expect_success 'am applies hg patch' '
 	test_cmp_rev second^ HEAD^
 '
 
+test_expect_success 'am --patch-format=hg applies hg patch' '
+	rm -fr .git/rebase-apply &&
+	git checkout -f first &&
+	git am --patch-format=hg <patch1-hg.eml &&
+	test_path_is_missing .git/rebase-apply &&
+	git diff --exit-code second &&
+	test_cmp_rev second HEAD &&
+	test_cmp_rev second^ HEAD^
+'
+
 test_expect_success 'setup: new author and committer' '
 	GIT_AUTHOR_NAME="Another Thor" &&
 	GIT_AUTHOR_EMAIL="a.thor@example.com" &&
-- 
2.1.4
Previous: Paul TanNext: Junio C Hamano
Message 6 of 7 in “am: improve test coverage and touch up foreign patch parsing”
  1. 0/5 am: improve test coverage and touch up foreign patch parsingPaul Tan, Jun 15, 2015
  2. 1/5 t4150: test applying StGit patchPaul Tan, Jun 15, 2015
  3. 2/5 am: teach StGit patch parser how to read from stdinPaul Tan, Jun 15, 2015
  4. 3/5 t4150: test applying StGit seriesPaul Tan, Jun 15, 2015
  5. 4/5 am: use gmtime() to parse mercurial patch datePaul Tan, Jun 15, 2015
  6. 5/5 am: teach mercurial patch parser how to read from stdinPaul Tan, Jun 15, 2015
  7. Junio C HamanoJun 15, 2015

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.