git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCHv3 0/4] git-p4: fixing --changes-block-size handling

From
Luke Diamand <luke@diamand.org>
Date
Jun 10, 2015, 07:30 UTC
Message-ID
<1433921459-16555-1-git-send-email-luke@diamand.org>

This series of patches teaches git-p4 to break up calls to the P4 server into smaller chunks, to avoid hitting the maxresults and maxscanrows server-side limits.

The previous iteration of this series didn't handle non-integer P4 revision ranges (e.g. //depot/...@2014/1/1,2015/1/1).

This version now breaks up the commit into blocks iff the revision range specified is an integer range: @all, M,N or N,#head. If the range is non-numeric then it falls back to relying on Perforce to parse the revisions. In this mode it is no longer possible to fetch changes in blocks (and requests to do so will be rejected).

Another alternative would be to turn the date (or whatever) revisions into numeric revision numbers, but there doesn't seem to be a simple way to do this. The best I can come up with is to get the changes "around" the date in question (perhaps binary-chopping from years down to seconds to find a range that works?) and then take the lowest revision supplied. But that's quite a bit more complex.

Luke Diamand (4):
  git-p4: additional testing of --changes-block-size
  git-p4: test with limited p4 server results
  git-p4: add tests for non-numeric revision range
  git-p4: fixing --changes-block-size handling
 git-p4.py               | 85 ++++++++++++++++++++++++++++++++++++-------------
 t/t9800-git-p4-basic.sh | 38 ++++++++++++++++++++++
 t/t9818-git-p4-block.sh | 73 ++++++++++++++++++++++++++++++++++++------
 3 files changed, 165 insertions(+), 31 deletions(-)
-- 
2.4.1.502.gb11c5ab
Next: Luke Diamand
Message 1 of 6 in “[PATCHv3 0/4] git-p4: fixing --changes-block-size handling”
  1. Luke DiamandJun 10, 2015
  2. 1/4 git-p4: additional testing of --changes-block-sizeLuke Diamand, Jun 10, 2015
  3. 2/4 git-p4: test with limited p4 server resultsLuke Diamand, Jun 10, 2015
  4. 3/4 git-p4: add tests for non-numeric revision rangeLuke Diamand, Jun 10, 2015
  5. 4/4 git-p4: fixing --changes-block-size handlingLuke Diamand, Jun 10, 2015
  6. Lex SpoonJun 12, 2015

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.