git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 3/6] am --skip: support skipping while on unborn branch

From
Paul Tan <pyokagan@gmail.com>
Date
Jun 6, 2015, 11:46 UTC
Message-ID
<1433591172-27077-4-git-send-email-pyokagan@gmail.com>
In-Reply-To
<1433591172-27077-1-git-send-email-pyokagan@gmail.com>

When git am --skip is run, git am will copy HEAD's tree entries to the index with "git reset HEAD". However, on an unborn branch, HEAD does not point to a tree, so "git reset HEAD" will fail.

Fix this by treating HEAD as en empty tree when we are on an unborn branch.

Signed-off-by: Paul Tan <pyokagan@gmail.com>
---
 git-am.sh           |  4 +---
 t/t4151-am-abort.sh | 10 ++++++++++
 2 files changed, 11 insertions(+), 3 deletions(-)
diff --git a/git-am.sh b/git-am.sh
index c847b58..67f4f25 100755
--- a/git-am.sh
+++ b/git-am.sh
@@ -509,9 +509,7 @@ then
 		git read-tree --reset -u $head_tree $head_tree &&
 		index_tree=$(git write-tree) &&
 		git read-tree -m -u $index_tree $head_tree
-		orig_head=$(cat "$GIT_DIR/ORIG_HEAD")
-		git reset HEAD
-		git update-ref ORIG_HEAD $orig_head
+		git read-tree $head_tree
 		;;
 	,t)
 		if test -f "$dotest/rebasing"
diff --git a/t/t4151-am-abort.sh b/t/t4151-am-abort.sh
index b618ee0..ea4a49e 100755
--- a/t/t4151-am-abort.sh
+++ b/t/t4151-am-abort.sh
@@ -92,4 +92,14 @@ test_expect_success 'am -3 stops on conflict on unborn branch' '
 	test 4 = "$(cat otherfile-4)"
 '
 
+test_expect_success 'am -3 --skip clears index on unborn branch' '
+	test_path_is_dir .git/rebase-apply &&
+	echo tmpfile >tmpfile &&
+	git add tmpfile &&
+	git am --skip &&
+	test -z "$(git ls-files)" &&
+	test_path_is_missing otherfile-4 &&
+	test_path_is_missing tmpfile
+'
+
 test_done
-- 
2.1.4
Previous: Paul TanNext: Paul Tan
Message 4 of 13 in “am --skip/--abort: improve index/worktree cleanup”
  1. 0/6 am --skip/--abort: improve index/worktree cleanupPaul Tan, Jun 6, 2015
  2. 1/6 am --skip: revert changes introduced by failed 3way mergePaul Tan, Jun 6, 2015
  3. 2/6 am -3: support 3way merge on unborn branchPaul Tan, Jun 6, 2015
  4. 3/6 am --skip: support skipping while on unborn branchPaul Tan, Jun 6, 2015
  5. 4/6 am --abort: revert changes introduced by failed 3way mergePaul Tan, Jun 6, 2015
  6. Junio C HamanoJun 8, 2015
  7. 5/6 am --abort: support aborting to unborn branchPaul Tan, Jun 6, 2015
  8. Junio C HamanoJun 8, 2015
  9. Paul TanJun 9, 2015
  10. 6/6 am --abort: keep unrelated commits on unborn branchPaul Tan, Jun 6, 2015
  11. Junio C HamanoJun 8, 2015
  12. Paul TanJun 9, 2015
  13. Stefan BellerJun 8, 2015

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.